Core Developers
  • Content count

  • Joined

  • Last visited

  • Days Won


Everything posted by meko

  1. if you want double quotes to be part of a string you have to escape them "foo \"bar\" baz"
  2. the errors here are quite explicit: you are using variables that are not declared (ep, char_id); you will have to declare them in the parameters of the function or inside the function before they can be used
  3. This is a bug and is fixed in This patch should land in the next release but meanwhile you can manually apply it
  4. Contribute to open source and get a free limited-edition T-shirt What's Hacktoberfest? Hacktoberfest — brought to you by DigitalOcean in partnership with GitHub and Twilio — is a month-long celebration of open source software. Maintainers are invited to guide would-be contributors towards issues that will help move the project forward, and contributors get the opportunity to give back to both projects they like, and ones they've just discovered. No contribution is too small—bug fixes and documentation updates are valid ways of participating. From October 1 to October 31, contribute to any open source project (Hercules included) on GitHub to get a free T-shirt! 5 pull requests are required. (Pull requests do not have to be merged and accepted; as long as they've been opened between the very start of October 1 and the very end of October 31, they count towards a free T-shirt.) We will be marking easy-to-tackle issues with the Hacktoberfest tag so that first time contributors can more easily find them. >> Register on Resources GitHub Learning Lab How to create a Pull Request on GitHub Understanding the GitHub Flow Open source 101 Hercules documentation Hercules wiki FAQ It is free to participate? Yes! Is shipping included? Yes. DigitalOcean offers free worldwide shipping. What shirt sizes are available for Hacktoberfest 2018? DigitalOcean have not yet made public the size chart for 2018, but we know they at least offer S to 4XL sizes, for both male and female. What's included in the package? A thank you letter. A T-Shirt. A bunch of cool stickers. Do I need to register for Hacktoberfest before starting to open Pull Requests? No. You may register at any time during the month of October and DigitalOcean will count your pull requests retroactively from October 1 onwards. Do all of my Pull Requests have to be sent to the same repository? No. You may send PRs to any number of repositories you like, and as long as they are public and have an OSI-approved license they will count towards the 5+ PRs objective. Do I have to wait for the start of October to open Pull Requests? You may contribute all year long, but only PRs that are opened during the month of October will be counted.
  5. Thank you! Hercules would like to thank everyone who contributed for hukktoberfest 2018 linton-dawson (newcomer) (first-time contributor) akshat157 (newcomer) (first-time contributor) @Emistry (staff) @KirieZ @Dastgir (staff) IpshitaC (newcomer) (first-time contributor) @Asheraf (staff) @Kubix (first-time contributor) @Habilis (first-time contributor) 🦄 shouxian92 (first-time contributor) jvastbinder (first-time contributor) @4144 (staff) @Myriad j-chad (newcomer) (first-time contributor) MohanSha (newcomer) (first-time contributor) BinaryCrochet (newcomer) (first-time contributor) @kisuka (staff) 🐺 VictoriaLa (newcomer) (first-time contributor) List of pull requests: We hope to see you again next year! ✨🎉
  6. Just run it natively on windows: Otherwise, you might want to consider WSL
  7. It's the last week of Hacktoberfest! If you’ve already completed 5 or more pull requests, you’ll be hearing from DigitalOcean via email soon for them to collect your address and t-shirt size. If you’re still working on reaching your goal, keep in mind that you may contribute to any project on GitHub, not just Hercules. (yes, even rAthena) Click here to find issues labeled "Hacktoberfest" on GitHub. Hacktoberfest values: Everyone is welcome! – This program welcomes everyone already in the open source software community, and anyone who is interested in diving in. Quantity is fun, Quality is key – Participating leads to personal growth, professional opportunities, and community building. It all starts with meaningful contributions. Short term action, long term impact – We stand on the shoulders of those who came before us. Your participation has a lasting effect long after October. Happy hukking 🎃
  8. you'll want to look into the item options system:
  9. @Rebel thanks for the second bug report! I have updated the pull request
  10. @Rebel this should fix your crash:
  11. wow that's quite awkward then; we should definitely get rid of it I'll open a PR to remove useless usages of getd
  12. sorry, we do not provide support for rAthena, however the following should work: [email protected]_id = monster("prontera", 150, 150, "Poring", PORING, 1); setunitdata([email protected]_id, UDT_MAXHP, 100000); setunitdata([email protected]_id, UDT_HP, 100000); Also keep in mind that mob events are called upon death, not summon
  13. @Darius Trevor This is fixed in but please use constants directly instead of using getd
  14. ARCH_MERC_GUILD, SPEAR_MERC_GUILD and SWORD_MERC_GUILD are hardcoded constants, so you cannot use them as variable Instead of doing something like this to get their values: setarray([email protected]$, "SPEAR_MERC_GUILD", "SWORD_MERC_GUILD", "ARCH_MERC_GUILD"); ... getd([email protected]$[1]) Just use the plain constants: setarray([email protected], SPEAR_MERC_GUILD, SWORD_MERC_GUILD, ARCH_MERC_GUILD); ... [email protected][1]
  15. setunitdata() was added in April 2017, so if you have a recent version of Hercules you should already have it. You can find the documentation in doc/script_commands.txt
  16. Since Hercules now uses LGTM, If you fix code quality issues during the month of October, Semmle (the company behind LGTM) will donate $3 to the World Wildlife Fund (WWF) to protect endangered species for every point you obtain. You can also win nice prizes, such as a free ticket to GitHub Universe 2018 (including travel and accommodation), a Holy Stone HS160 Shadow FPV camera drone, or a Raspberry PI 3 B+ Starter Kit development board. Points will only be awarded for fixes that reach the main branch of a project’s repository (i.e. for Pull Requests that are merged), and will be awarded as follows: 1 point per recommendation, 3 points per warning, and 5 points per error fixed. Since Hercules has automatic code review enabled, then points awarded for fixes will be 3x the normal amount. This means 3 points, 9 points, and 15 points. So for example, if a participant fixes 3 errors, they will be awarded 45 points ((3 * 5) * 3), and Semmle will donate $135 to WWF. >>>> Register on
  17. @MikZ this PR should fix your issue:
  18. @MikZ yes, nevermind, it seems this function is actually called from pc.c when a player spends or obtains zeny. I'll submit a patch shortly
  19. this script does not use queuesize() so it cannot trigger this warning, this means your issue is in another script, not this one
  20. db/(pre-)re/achiemement_db.conf
  21. 'amount ! =0! in function 'achievement_validate_zeny this is pretty explicit, it means you put a zeny achievement in the achievement db with Goal: 0, which is invalid, because players cannot spend -0 or gain +0 zeny
  22. I have made a script to automatically set up the sql connection on new Hercules installations. The script does the following: Installs Chocolatey (for easy installation and upgrading of MariaDB) Installs the latest MariaDB version from Chocolatey Resets the root password for MariaDB, and adds a Hercules user Creates a Hercules database and imports the main.sql file Updates the configuration files so that Hercules uses the new database You can download the script here: Save the file as mariadb.bat, at the root of your Hercules folder Right-click on the file and do "Run as administrator" Follow the on-screen prompts
  23. simply follow the on-screen instructions when running the MariaDB windows installer. it should ask you to set a root password, and then you can install HeidiSQL and use it to connect to your local MariaDB server. Choose as server, root as username, and the password you chose during installation as password. Once you are connected you can make a database for herc and add a new user with access to said database (to avoid using root). You can then login with that new user and choose the database you created and then import the .sql files. Once the database setup is complete, update the sql_connection.conf file to tell Hercules what user and password it should use
  24. well, do you actually have an sql server running, and did you edit sql_connection.conf accordingly? you can get mariadb on
  25. Hacktoberfest