AnnieRuru

Charms

17 posts in this topic

If there's 2 jellopy on hand, will it stack the effect? Can we have an option for 'stackable' or non-stackable effects?

Edited by Kong

Share this post


Link to post
Share on other sites

If there's 2 jellopy on hand, will it stack the effect?

yes,

when I test, having 2 jellopy, my str bonus become +20000

.

.

Can we have an option for 'stackable' or non-stackable effects?

nice idea actually

maybe can add another field "Stack_Charm: true" to only give 1 effect per item ID

Edited by AnnieRuru

Share this post


Link to post
Share on other sites

as always, thank you ma'am..  :wub:

 

OOT:

are you using visual studio ma'am ? and in other topic there is saying (forgot who is saying this) the project (plugin project (sample plugin project)) can be copy pasted to make other plugin to work, are you using this method? if yes can you make tutorial about it? the lazy and ungrateful me is always have to open wiki to get the plugin to work

Share this post


Link to post
Share on other sites

upload version 1.1

https://drive.google.com/file/d/0B2BM920mmHQganoxY0hTUktkUzQ/view

please make do with the google drive, because I accidentally upload the paste without log in

 

- added Charm_Stack: true flag, credit to Litro and Kong for the idea

- however it always run the status_calc_pc even if the player still having the item in the inventory

 

 

and I'm going to watch star wars on the theater now

Share this post


Link to post
Share on other sites

upload version 1.1

https://drive.google.com/file/d/0B2BM920mmHQganoxY0hTUktkUzQ/view

please make do with the google drive, because I accidentally upload the paste without log in

 

- added Charm_Stack: true flag, credit to Litro and Kong for the idea

- however it always run the status_calc_pc even if the player still having the item in the inventory

 

 

and I'm going to watch star wars on the theater now

Thank you! :D

Share this post


Link to post
Share on other sites

@@AnnieRuru

 

hi annieruru im planning to implement this in my live server, before i i put this in my server i just want to ask if this plugin is a complete no bug? or safe to use in a live server?

Share this post


Link to post
Share on other sites

I think its safe,

since the day I fixed that digitalhanster's patch on eathena forum,

I never heard anything wrong about that

and I'm sure that patch is still used by many rathena server out there

 

the one made by dastgir can dup item,

because originally, the status_calc_pc should run AFTER the item deleted,

but he made it run before the item deleted, thus it never has the chance to run memset into null

https://github.com/HerculesWS/Hercules/blob/22d3fac0c9a9c39a4f3b544867ba1de4d8d2ecaa/src/map/pc.c#L4553-L4554

the item memory is still there thus can duplicate the item

 

I solved it with a little trick, its on the comment

 

I just tested with the *mergeitem script command

yup, I also can't reproduce any bug

with the "Charm_Stack: false", I have 10 jellopy, the merge window doesn't show the jellopy

Share this post


Link to post
Share on other sites

I think its safe,

since the day I fixed that digitalhanster's patch on eathena forum,

I never heard anything wrong about that

and I'm sure that patch is still used by many rathena server out there

 

the one made by dastgir can dup item,

because originally, the status_calc_pc should run AFTER the item deleted,

but he made it run before the item deleted, thus it never has the chance to run memset into null

https://github.com/HerculesWS/Hercules/blob/22d3fac0c9a9c39a4f3b544867ba1de4d8d2ecaa/src/map/pc.c#L4553-L4554

the item memory is still there thus can duplicate the item

 

I solved it with a little trick, its on the comment

 

I just tested with the *mergeitem script command

yup, I also can't reproduce any bug

with the "Charm_Stack: false", I have 10 jellopy, the merge window doesn't show the jellopy

 

 

Hi Annie, the console gives an error when i make plugins

 

Any idea what it is? I'm using charms 1.1 Thanks a lot for the release btw. :)

 

post-1961-0-93378300-1456487866_thumb.png

Share this post


Link to post
Share on other sites

 

I think its safe,

since the day I fixed that digitalhanster's patch on eathena forum,

I never heard anything wrong about that

and I'm sure that patch is still used by many rathena server out there

 

the one made by dastgir can dup item,

because originally, the status_calc_pc should run AFTER the item deleted,

but he made it run before the item deleted, thus it never has the chance to run memset into null

https://github.com/HerculesWS/Hercules/blob/22d3fac0c9a9c39a4f3b544867ba1de4d8d2ecaa/src/map/pc.c#L4553-L4554

the item memory is still there thus can duplicate the item

 

I solved it with a little trick, its on the comment

 

I just tested with the *mergeitem script command

yup, I also can't reproduce any bug

with the "Charm_Stack: false", I have 10 jellopy, the merge window doesn't show the jellopy

 

 

Hi Annie, the console gives an error when i make plugins

 

Any idea what it is? I'm using charms 1.1 Thanks a lot for the release btw. :)

 

attachicon.gifUntitled.png

 

@@Dastgir might be able to update it for us if he got any free time  :wub:  :wub:

Share this post


Link to post
Share on other sites

 

 

I think its safe,

since the day I fixed that digitalhanster's patch on eathena forum,

I never heard anything wrong about that

and I'm sure that patch is still used by many rathena server out there

 

the one made by dastgir can dup item,

because originally, the status_calc_pc should run AFTER the item deleted,

but he made it run before the item deleted, thus it never has the chance to run memset into null

https://github.com/HerculesWS/Hercules/blob/22d3fac0c9a9c39a4f3b544867ba1de4d8d2ecaa/src/map/pc.c#L4553-L4554

the item memory is still there thus can duplicate the item

 

I solved it with a little trick, its on the comment

 

I just tested with the *mergeitem script command

yup, I also can't reproduce any bug

with the "Charm_Stack: false", I have 10 jellopy, the merge window doesn't show the jellopy

 

 

Hi Annie, the console gives an error when i make plugins

 

Any idea what it is? I'm using charms 1.1 Thanks a lot for the release btw. :)

 

attachicon.gifUntitled.png

 

@@Dastgir might be able to update it for us if he got any free time  :wub:  :wub:

My Free Times comes too late :( :(

Anyways, Here it is: https://github.com/dastgir/HPM-Plugins/blob/master/src/plugins/CharmSystem.c

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now