• 0
nuna

Good day! Preview Bug ( Quest shop npc )

Question

Hello everyone. the quest_shop.txt npc of euphys has a bug.

Preview bug. 

Players can make the normal item as a costume by using the preview option.

 

Since i dont like it to be exploit. For the Scripter Hercules community. Please send me a message and i will let you know the steps on how to perform the minor bug.

Share this post


Link to post
Share on other sites

21 answers to this question

  • 0

Waiting for someone to message you on how to replicate the bug might take some time.. Maybe it would be much easier if you will post how to do it and others can help you with this.

Share this post


Link to post
Share on other sites
  • 0

Maybe it would be much easier if you will post how to do it and others can help you with this.

That'd be inconsiderate for servers that use that script and I know lots that do.

Share this post


Link to post
Share on other sites
  • 0

This on herc is a pretty old version, isn't it fixed in the new ones? Maybe we should update it too.

And as the others said, how are we supposed to provide support without knowing how to perform the exploit?

Share this post


Link to post
Share on other sites
  • 0

This on herc is a pretty old version, isn't it fixed in the new ones? Maybe we should update it too.

And as the others said, how are we supposed to provide support without knowing how to perform the exploit?

 

 

Ok heres how you do it. First prepare your normal hat (You want to function like a costume) then go the the quest shop npc. Buy headgear and choose preview. After choosing preview, unequip your hat then choose cancel. (the normal hat display will remain in your character. )

 

Another is uniquip your hat. Choose preview then after choosing preview. Equip your normal hat then choose cancel. even though you have equipped costume and normal hat,

 still your character display will not display any headgears at all.

 

Share this post


Link to post
Share on other sites
  • 0

if the issue comes only when you equip or unequip a hat then adding a 

disable_items();

should fix it

Edited by Asheraf

Share this post


Link to post
Share on other sites
  • 0

if the issue comes only when you equip or unequip a hat then adding a 

 

disable_items();
should fix it

Share this post


Link to post
Share on other sites
  • 0

if the issue comes only when you equip or unequip a hat then adding a 

disable_items();

should fix it

Thank you for the solution, but may i ask where should i put that. What line?

Share this post


Link to post
Share on other sites
  • 0

On phone and not having the script here, usually in raw very first line of the npc

Share this post


Link to post
Share on other sites
  • 0

On phone and not having the script here, usually in raw very first line of the npc

//===== Hercules Script ======================================
//= Euphy's Quest Shop
//===== By: ==================================================
//= Euphy
//===== Current Version: =====================================
//= 1.6a
//===== Description: =========================================
//= A dynamic quest shop based on Lunar's, with easier config.
//= Includes support for multiple shops & cashpoints.
//= Item Preview script by ToastOfDoom.
//===== Additional Comments: =================================
//= 1.0 Initial script.
//= 1.2 Added category support.
//= 1.3 More options and fixes.
//= 1.4 Added debug settings.
//= 1.5 Replaced categories with shop IDs.
//= 1.6 Added support for purchasing stackables.
//= 1.6a Added support for previewing costumes and robes.
//============================================================

// Shop NPCs -- supplying no argument displays entire menu.
//	callfunc "qshop"{,<shop ID>{,<shop ID>{,...}}};
//============================================================
prontera,164,203,6	script	Quest Shop#1	4_M_MOCASS2,{ callfunc "qshop"; }


// Script Core
//============================================================
-	script	quest_shop	FAKE_NPC,{
function Add; function Chk; function Slot; function A_An;
OnInit:
	freeloop(1);

// -----------------------------------------------------------
//  Basic shop settings.
// -----------------------------------------------------------

	set .Announce,1;	// Announce quest completion? (1: yes / 0: no)
	set .ShowSlot,1;	// Show item slots? (2: all equipment / 1: if slots > 0 / 0: never)
	set .ShowID,0;  	// Show item IDs? (1: yes / 0: no)
	set .ShowZeny,0;	// Show Zeny cost, if any? (1: yes / 0: no)
	set .MaxStack,100;	// Max number of quest items purchased at one time.

// -----------------------------------------------------------
//  Points variable -- optional quest requirement.
//	setarray .Points$[0],"<variable name>","<display name>";
// -----------------------------------------------------------

	setarray .Points$[0],"#CASHPOINTS","Cash Points";

// -----------------------------------------------------------
//  Shop IDs -- to add shops, copy dummy data at bottom of file.
//	setarray .Shops$[1],"<Shop 1>","<Shop 2>"{,...};
// -----------------------------------------------------------

	setarray .Shops$[1],"Headgears","Weapons","Other";

// -----------------------------------------------------------
//  Quest items -- do NOT use a reward item more than once!
//	Add(<shop ID>,<reward ID>,<reward amount>,
//	    <Zeny cost>,<point cost>,
//	    <required item ID>,<required item amount>{,...});
// -----------------------------------------------------------

	Add(1,5022,1,0,0,7086,1,969,10,999,40,1003,50,984,2);
	Add(1,5032,1,0,0,1059,250,2221,1,2227,1,7063,600);
	Add(1,5027,1,0,0,2252,1,1036,400,7001,50,4052,1);
	Add(1,5045,1,0,0,2252,1,1054,450,943,1200);

	Add(2,1224,1,0,0,7297,30,969,10,999,50,714,10);
	Add(2,1225,1,0,0,7292,30,969,10,999,50,714,10);

	Add(3,531,1,3,0,512,1,713,1);
	Add(3,532,1,3,0,513,1,713,1);
	Add(3,533,1,3,0,514,1,713,1);
	Add(3,534,1,3,0,515,1,713,1);

// -----------------------------------------------------------

	freeloop(0);
	set .menu$,"";
	for(set [email protected],1; [email protected]<=getarraysize(.Shops$); set [email protected],[email protected]+1) {
		set .menu$, .menu$+.Shops$[[email protected]]+":";
		npcshopdelitem "qshop"[email protected],909;
	}
	end;

OnMenu:
	set [email protected], getarraysize(@i);
	if ([email protected]) set [email protected], select(.menu$);
	else if ([email protected] == 1) set [email protected], @i[0];
	else {
		for(set [email protected],0; [email protected]<[email protected]; set [email protected],[email protected]+1)
			set [email protected]$, [email protected]$+.Shops$[@i[[email protected]]]+":";
		set [email protected], @i[select([email protected]$)-1];
	}
	deletearray @i[0],getarraysize(@i);
	if (.Shops$[[email protected]] == "") {
		message strcharinfo(PC_NAME),"An error has occurred.";
		end;
	}
	dispbottom "Select one item at a time.";
	callshop "qshop"[email protected],1;
	npcshopattach "qshop"[email protected];
	end;

OnBuyItem:
	// [email protected][] : RewardID, BoughtAmt, RewardAmt, BaseAmt, ReqZeny, ReqPts, { ReqItem, ReqAmt, ... }
	setarray [email protected][0],@bought_nameid[0],((@bought_quantity[0] > .MaxStack)?.MaxStack:@bought_quantity[0]);
	copyarray [email protected][3],getd(".q_"[email protected][0]+"[0]"),getarraysize(getd(".q_"[email protected][0]));
	set [email protected][2],[email protected][1]*[email protected][3];
	if ([email protected][2] || [email protected][2] > 30000) {
		message strcharinfo(PC_NAME),"You can't purchase that many "+getitemname([email protected][0])+".";
		end;
	}
	mes "[Quest Shop]";
	mes "Reward: ^0055FF"+(([email protected][2] > 1)[email protected][2]+"x ":"")+Slot([email protected][0])+"^000000";
	mes "Requirements:";
	if ([email protected][4]) mes " > "+Chk(Zeny,[email protected][4]*[email protected][1])+([email protected][4]*[email protected][1])+" Zeny^000000";
	if ([email protected][5]) mes " > "+Chk(getd(.Points$[0]),[email protected][5]*[email protected][1])+([email protected][5]*[email protected][1])+" "+.Points$[1]+" ("+getd(.Points$[0])+"/"+([email protected][5]*[email protected][1])+")^000000";
	if ([email protected][6]) for(set [email protected],6; [email protected]<getarraysize([email protected]); set [email protected],[email protected]+2)
		mes " > "+Chk(countitem([email protected][[email protected]]),[email protected][[email protected]+1]*[email protected][1])+((.ShowID)?"{"[email protected][[email protected]]+"} ":"")+Slot([email protected][[email protected]])+" ("+countitem([email protected][[email protected]])+"/"+([email protected][[email protected]+1]*[email protected][1])+")^000000";
	next;
	setarray @qe[1], getiteminfo([email protected][0],5), getiteminfo([email protected][0],11);
	if (@qe[2] > 0 && ((@qe[1] & 1) || (@qe[1] & 256) || (@qe[1] & 512) || (@qe[1] & 1024) || (@qe[1] & 2048) || (@qe[1] & 4096) || (@qe[1] & 4) || (@qe[1] & 8192)))
		set [email protected],1;
	addtimer 1000, strnpcinfo(NPC_NAME)+"::OnEnd";
	while(1) {
		switch(select(" ~ Purchase ^0055FF"+ getitemname([email protected][0]) +"^000000", (([email protected] && [email protected][7])?" ~ Preview...": ""), " ~ ^777777Cancel^000000")) {
		case 1:
			if (@qe[0]) {
				mes "[Quest Shop]";
				mes "You're missing one or more quest requirements.";
				close;
			}
			if (!checkweight([email protected][0],[email protected][2])) {
				mes "[Quest Shop]";
				mes "^FF0000You need "+((([email protected][2]*getiteminfo([email protected][0],6))+Weight-MaxWeight)/10)+" additional weight capacity to complete this trade.^000000";
				close;
			}
			if ([email protected][4]) Zeny -= ([email protected][4]*[email protected][1]);
			if ([email protected][5]) setd .Points$[0], getd(.Points$[0])-([email protected][5]*[email protected][1]);
			if ([email protected][6]) for(set [email protected],6; [email protected]<getarraysize([email protected]); set [email protected],[email protected]+2)
				delitem [email protected][[email protected]],[email protected][[email protected]+1]*[email protected][1];
			getitem [email protected][0],[email protected][2];
			if (.Announce) announce strcharinfo(PC_NAME)+" has created "+(([email protected][2] > 1)[email protected][2]+"x "+getitemname([email protected][0]):A_An(getitemname([email protected][0])))+"!",0;
			specialeffect2 EF_FLOWERLEAF;
			close;
		case 2:
			setarray @qe[3], getlook(LOOK_HEAD_BOTTOM), getlook(LOOK_HEAD_TOP), getlook(LOOK_HEAD_MID), getlook(LOOK_ROBE), 1;
			if ((@qe[1] & 1) || (@qe[1] & 4096)) changelook LOOK_HEAD_BOTTOM, @qe[2];
			else if ((@qe[1] & 256) || (@qe[1] & 1024)) changelook LOOK_HEAD_TOP, @qe[2];
			else if ((@qe[1] & 512) || (@qe[1] & 2048)) changelook LOOK_HEAD_MID, @qe[2];
			else if ((@qe[1] & 4) || (@qe[1] & 8192)) changelook LOOK_ROBE, @qe[2];
			break;
		case 3:
			close;
		}
	}

OnEnd:
	if (@qe[7]) {
		changelook LOOK_HEAD_BOTTOM, @qe[3];
		changelook LOOK_HEAD_TOP, @qe[4];
		changelook LOOK_HEAD_MID, @qe[5];
		changelook LOOK_ROBE, @qe[6];
	}
	deletearray @qe[0],8;
	end;

function Add {
	if (getitemname(getarg(1)) == "null") {
		debugmes "Quest reward #"+getarg(1)+" invalid (skipped).";
		return;
	}
	setarray [email protected][0],getarg(2),getarg(3),getarg(4);
	for(set [email protected],5; [email protected]<getargcount(); set [email protected],[email protected]+2) {
		if (getitemname(getarg([email protected])) == "null") {
			debugmes "Quest requirement #"+getarg([email protected])+" invalid (skipped).";
			return;
		} else
			setarray [email protected][[email protected]],getarg([email protected]),getarg([email protected]+1);
	}
	copyarray getd(".q_"+getarg(1)+"[0]"),[email protected][0],getarraysize([email protected]);
	npcshopadditem "qshop"+getarg(0),getarg(1),((.ShowZeny)?getarg(3):0);
	return;
}

function Chk {
	if (getarg(0) < getarg(1)) {
		set @qe[0],1;
		return "^FF0000";
	} else
		return "^00FF00";
}

function Slot {
	set [email protected]$,getitemname(getarg(0));
	switch(.ShowSlot) {
		case 1: if (!getitemslots(getarg(0))) return [email protected]$;
		case 2: if (getiteminfo(getarg(0),2) == 4 || getiteminfo(getarg(0),2) == 5) return [email protected]$+" ["+getitemslots(getarg(0))+"]";
		default: return [email protected]$;
	}
}

function A_An {
	setarray [email protected]$[0],"a","e","i","o","u";
	set [email protected]$, "_"+getarg(0);
	for(set [email protected],0; [email protected]<5; set [email protected],[email protected]+1)
		if (compare([email protected]$,"_"[email protected]$[[email protected]])) return "an "+getarg(0);
	return "a "+getarg(0);
}
}

function	script	qshop	{
	deletearray @i[0],getarraysize(@i);
	for(set [email protected],0; [email protected]<getargcount(); set [email protected],[email protected]+1)
		set @i[[email protected]],getarg([email protected]);
	doevent "quest_shop::OnMenu";
	end;
}


// Dummy shop data -- copy as needed.
//============================================================
-	shop	qshop1	FAKE_NPC,909:-1
-	shop	qshop2	FAKE_NPC,909:-1
-	shop	qshop3	FAKE_NPC,909:-1
-	shop	qshop4	FAKE_NPC,909:-1
-	shop	qshop5	FAKE_NPC,909:-1

Hello thank you please check the code now hehe

Share this post


Link to post
Share on other sites
  • 0

put it under OnBuyItem

Hello sir it doesnt work.

 

 

Hercules/conf/map/battle/items.conf

item_enabled_npc: true -> false

Thanks but i only want it in the script not in global.

Share this post


Link to post
Share on other sites
  • 0

make it 

OnBuyItem:
	disable_items();

and you wont be able to equip or enquip items during the buy/preview 

Share this post


Link to post
Share on other sites
  • 0

make it 

OnBuyItem:
	disable_items();

and you wont be able to equip or enquip items during the buy/preview 

 

It only work upon reloading the script. but upon starting the server it wont work. Hope you get my point

Share this post


Link to post
Share on other sites
  • 0

 

put it under OnBuyItem

Hello sir it doesnt work.

 

 

>>Hercules/conf/map/battle/items.conf

item_enabled_npc: true -> false

Thanks but i only want it in the script not in global.

 

ok replace OnEnd: ...... end;   with

 

OnEnd:
	if (@qe[7]) {
		if ( @qe[1] & EQP_HEAD_TOP ) {
			set [email protected], getequipid(EQI_HEAD_TOP);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_HEAD_TOP, [email protected];
		}
		if ( @qe[1] & EQP_HEAD_MID && !(@qe[1]&EQP_HEAD_TOP)) {
			set [email protected], getequipid(EQI_HEAD_MID);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_HEAD_MID, [email protected];
		}
		if ( @qe[1] & EQP_HEAD_LOW && !(@qe[1]&(EQP_HEAD_TOP|EQP_HEAD_MID)) ) {
			set [email protected], getequipid(EQI_HEAD_LOW);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_HEAD_LOW, [email protected];
		}
		if ( @qe[1] & EQP_COSTUME_HEAD_TOP) {
			set [email protected], getequipid(EQI_COSTUME_HEAD_TOP);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_HEAD_TOP, [email protected];
		}
		if ( @qe[1] & EQP_COSTUME_HEAD_MID && !(@qe[1]&(EQP_HEAD_TOP|EQP_COSTUME_HEAD_TOP))) {
			set [email protected], getequipid(EQI_COSTUME_HEAD_MID);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_HEAD_MID, [email protected];
		}
		if ( @qe[1] & EQP_COSTUME_HEAD_LOW && !(@qe[1]&(EQP_HEAD_TOP|EQP_COSTUME_HEAD_TOP|EQP_HEAD_MID|EQP_COSTUME_HEAD_MID)) ) {
			set [email protected], getequipid(EQI_COSTUME_HEAD_LOW);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_HEAD_BOTTOM, [email protected];
		}
		if ( @qe[1]&EQP_GARMENT ) {
			set [email protected], getequipid(EQI_GARMENT);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_ROBE, [email protected];
		}
		if ( @qe[1] & EQP_COSTUME_GARMENT) {
			set [email protected], getequipid(EQI_COSTUME_GARMENT);
			if ([email protected] > 0 )
				set [email protected], getiteminfo([email protected],11);
			changelook LOOK_ROBE, [email protected];
		}
	}
	deletearray @qe;
	end;
Edited by Kaori

Share this post


Link to post
Share on other sites
  • 0

NB

 

 

make it 

OnBuyItem:
	disable_items();

and you wont be able to equip or enquip items during the buy/preview 

 

It only work upon reloading the script. but upon starting the server it wont work. Hope you get my point

hmm~

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now