Jump to content
Sephus

Hercules Battlegrounds

Recommended Posts

On 15/12/2017 at 10:20 AM, caspe said:

Alguém pode consertar isso?

On 25/11/2017 at 2:59 AM, melv0 said:

someboody can help me to fix this error??

char.png.2ebf5a3368ddb1068ece04f38507177d.png

Fixed in pull #36, f963865

Awaiting @Smoke approval. 

Edited by LucasBrito

Share this post


Link to post
Share on other sites

im getting this error on latest Herc
 

hBG.c: In function ‘hBG_addflooritem_area’:
hBG.c:1950:3: error: too few arguments to function ‘map->addflooritem’
   count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4) != 0) ? 1 : 0;

 

Share this post


Link to post
Share on other sites
On 1/16/2018 at 9:37 PM, astralprojection said:

im getting this error on latest Herc
 


hBG.c: In function ‘hBG_addflooritem_area’:
hBG.c:1950:3: error: too few arguments to function ‘map->addflooritem’
   count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4) != 0) ? 1 : 0;

 

Please help on this @LucasBrito @Smoke  thanks guys this plugin is amazing.

Share this post


Link to post
Share on other sites
On 1/16/2018 at 7:07 PM, astralprojection said:

im getting this error on latest Herc
 


hBG.c: In function ‘hBG_addflooritem_area’:
hBG.c:1950:3: error: too few arguments to function ‘map->addflooritem’
   count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4) != 0) ? 1 : 0;

 

same here, look like another emulator update cause this problem.

Share this post


Link to post
Share on other sites
On 17/01/2018 at 3:40 AM, astralprojection said:

thanks for asking @LucasBrito  i experience at 2015-10-29aRagexe

Please send me a complete 2015 client (data folder + hexed) through Google Drive so I can run the tests. I have no time to ride.

Share this post


Link to post
Share on other sites

@Smoke @LucasBrito can u revert BG emblem update?

because in newer client guild emblem does not show in BG map or require EnbleBGEmblem patch which has alignment problems.

better show battleground emblem at top of players head than show nothing. User can easily remove BG sword emblem by making them transparent.

Also if possible please check IP_check function, because it is not working.

Share this post


Link to post
Share on other sites
40 minutes ago, caspe said:

@Smoke @LucasBrito can u revert BG emblem update?

because in newer client guild emblem does not show in BG map or require EnbleBGEmblem patch which has alignment problems.

better show battleground emblem at top of players head than show nothing. User can easily remove BG sword emblem by making them transparent.

Also if possible please check IP_check function, because it is not working.

Just installed this plugin, wanted to try it out. I'm unsure what it was like before, but seems the BG Guild Emblems are not displaying correctly.
https://github.com/Smokexyz/HerculesBG/issues/39

@caspe it would be better to include #if PACKETVER <= clientver, replacing clientver with the last known compatible one. I'm not familiar with this plugin, but I guess it would be this part?
 

	/* Display emblem on head of char [lucaslsb] */
#if PACKETVER <= 20141022
	if (hBG_enabled && sd->state.changemap && map->list[sd->bl.m].flag.battleground)
		clif->map_type(sd, MAPTYPE_BATTLEFIELD);
	if (hBG_enabled && map->list[sd->bl.m].flag.battleground)
		clif->map_property(sd, MAPPROPERTY_AGITZONE);
#endif

and then,

		// clif interface overloading [lucaslsb]
#if PACKETVER <= 20141022
		clif->sendbgemblem_area = clif_sendbgemblem_area_overloading;
		clif->sendbgemblem_single = clif_sendbgemblem_single_overloading;
#endif

but after testing, it seems this is pointless, as the newer clients show the emblems just fine (read below). Better to add a config for whether you'd rather show the sword or not.

 ALSO your alignment issue is not exclusive to guild emblems. It's to do with the zoom in/out of your client. It can happen with some headgears to, such as ugly ass wings.

Exhibit A, zoomed in.
mElvGh5.png

Exhibit B, zoomed to an appropriate amount.
HWLLYMY.png

Edited by Myriad

Share this post


Link to post
Share on other sites

@Myriad Thanks for reply

Tested with 2015-10-29aRagexe client and emblem show property with enablebgemblem patch, no need to revert BG emblem changes.

Need to check other problem's. :blush:

@Stupidity Use 2015-10-29aRagexe or 2012 client

Share this post


Link to post
Share on other sites

compile warning on Ubuntu


hBG.c: In function ‘atcommand_reportafk’:
hBG.c:2040:31: warning: unused variable ‘hBGsd’ [-Wunused-variable]
  struct hBG_map_session_data *hBGsd = NULL;
                               ^
hBG.c: In function ‘atcommand_leader’:
hBG.c:2084:31: warning: unused variable ‘hBGsd’ [-Wunused-variable]
  struct hBG_map_session_data *hBGsd = NULL;
                               ^
hBG.c: In function ‘status_get_guild_id_pre’:
hBG.c:3776:31: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   && (bg_id = bg->team_get_id((struct block_list *)*bl)) > 0
                               ^
hBG.c: In function ‘status_get_emblem_id_pre’:
hBG.c:3797:31: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   && (bg_id = bg->team_get_id((struct block_list *)(*bl))) > 0
                               ^
hBG.c: In function ‘char_bgstats_tosql’:
hBG.c:4242:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
    "REPLACE INTO `char_bg_stats` ("
    ^
hBG.c: In function ‘hBG_build_guild_data’:
hBG.c:1719:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
    fread(&bg_guild[j].emblem_data, 1, bg_guild[j].emblem_len, fp);
 

Share this post


Link to post
Share on other sites

@Smoke this plugin having lot's of issue on ubuntu,

@Myriad i'm getting emblem problem, which u have mentioned

Also players need to use Shift to hit players.

 

I was testing this plugin on windows 7 & using visual studio to compile, now after adding it to the server which is hosted on Ubuntu.

many problem's start occurring.

 

OR can anyone tell me how should i build this plugin on Ubuntu? i'm using make plugins command

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.