Jump to content
evilpuncker

[Warning]: pc_bonusX: display itemID

give your input!  

14 members have voted

  1. 1. is it useful to go in the emulator

    • yes
      13
    • no
      1


Recommended Posts

based on all info here, I want to suggest the addition of itemID in that warning message so we can know which item is the one that we should fix instead of looking everywhere with no clue on where to start!

 

 

here is a diff that Cydh made for rA, I guess we can adapt it to Hercules as well...

 

pc_bonus_warnings.diff

Share this post


Link to post
Share on other sites

based on all info here, I want to suggest the addition of itemID in that warning message so we can know which item is the one that we should fix instead of looking everywhere with no clue on where to start!

 

 

here is a diff that Cydh made for rA, I guess we can adapt it to Hercules as well...

 

attachicon.gifpc_bonus_warnings.diff

I had a talk about this with Haru, and this isn't that simple,

There's some other things like pet/combo/status which run this function, and thus need more checking to display what caused the error and display it.

Surely this would be implemented soon..

Share this post


Link to post
Share on other sites

If I remember well, if we implement this, we probably need to implement other errors too, like what if error is from pet?

Share this post


Link to post
Share on other sites
 

I agree that Warning msgs should be improved, something like

[Warning]: itemid:xxxx pc_bonus: unknown type
[Warning]: itemid:aaaa pc_bonus2: unknown type
[Warning]: itemid:bbbb pc_bonus3: unknown type
[Warning]: itemid:ccc pc_bonus5: unknown type

 

Uhh yo so can we re-suggest this?

 

 

Credits to Angelmelody.

Share this post


Link to post
Share on other sites

Update:

We recently introduced assert report for this, so one can know which function(in src) is causing it

https://github.com/HerculesWS/Hercules/commit/8846818298750048288a39dc8072e15c7e67456d

 

still no item id I guess? xD or am I missing anything here? :P can you give us an example?

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.