Jump to content

Dark Theme was set as default for all members. Please report any issues here.

Kenpachi

Core Developers
  • Content Count

    107
  • Joined

  • Last visited

  • Days Won

    5

Kenpachi last won the day on November 24

Kenpachi had the most liked content!

7 Followers

About Kenpachi

  • Rank
    Advanced Member
  • Birthday 04/03/1984

Profile Information

  • Gender
    Male
  • Location:
    Germany

Recent Profile Visitors

2624 profile views
  1. Kenpachi

    savepoint

    Hi. Would be nice to see the script you're using to let us know how you store the IDs of chars that should have their save point changed. ~Kenpachi
  2. Hi. Quick and dirty. Partially tested. ~Kenpachi patch.diff
  3. Open script file in editor. Find the line which contains query_sql "DELETE FROM `viptable` ...... Set cursor to the end of that line (click behind the semicolon) Press Backspace. Save file. You'll notice that the semicolon wasn't removed, because you deleted the hidden character (whitespace) behind it. ~Kenpachi
  4. You can do this in OnClock0000 by running a simple SQL query. If your variable is a character variable: query_sql("DELETE FROM `char_reg_num_db` WHERE `key` = 'your_var_name'"); If it's an account variable: query_sql("DELETE FROM `acc_reg_num_db` WHERE `key` = '#your_var_name'"); ~Kenpachhi
  5. There is a hidden character behind the semicolon in that line. (Probably caused by text encoding mismatch.)
  6. Hi. Alter your SQL table: ALTER TABLE `viptable` ADD COLUMN `insert_on` DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP AFTER `email`; Or recreate it: DROP TABLE IF EXISTS `viptable`; CREATE TABLE `viptable` ( `vipacc_id` int(11) unsigned NOT NULL default '0', `vip_id` varchar(255) NOT NULL default '', `days` int(11) NOT NULL default '0', `email` varchar(39) NOT NULL default '', `insert_on` datetime NOT NULL DEFAULT CURRENT_TIMESTAMP, PRIMARY KEY (`vipacc_id`), KEY `name` (`vip_id`) ) ENGINE=MyISAM; Change your function (note line 2): function script F_TicketAddVip { Query_SQL "DELETE FROM `viptable` WHERE `vipacc_id` = '"+GetCharID(3)+"' AND DATEDIFF(DATE_ADD(`insert_on`, INTERVAL `days` DAY), NOW()) < 0"; // remove expired VIP status before reapplying Query_SQL "SELECT `days` FROM `viptable` WHERE `vipacc_id` = '"+GetCharID(3)+"'", [email protected]; if ([email protected] > 0) { Set [email protected], ([email protected] + 30); Query_SQL "UPDATE `viptable` SET `days`='"[email protected]+"' WHERE `vipacc_id`='"+GetCharID(3)+"'"; Query_SQL "SELECT `group_id` FROM `login` WHERE `account_id`='"+GetCharID(3)+"'", [email protected]; If ([email protected] < 1) Query_SQL "UPDATE `login` SET `group_id`='2' WHERE `account_id`='"+GetCharID(3)+"'"; } Else { Query_SQL "UPDATE `login` SET `group_id`='2' WHERE `account_id`='"+GetCharID(3)+"'"; Query_SQL "SELECT `userid` FROM `login` WHERE `account_id`='"+GetCharID(3)+"'", [email protected]$; Query_SQL "SELECT `email` FROM `login` WHERE `account_id`='"+GetCharID(3)+"'", [email protected]$; Query_SQL "INSERT INTO `viptable` (`vipacc_id`,`vip_id`,`days`,`email`) VALUES ('"+GetCharID(3)+"','"[email protected]$+"','30','"[email protected]$+"')"; } AtCommand "@reloadpcdb"; dispbottom "You received 30 days of VIP Account, congrats!"; specialeffect2 338; End; Return; } The info script could look like this: - script VIP_STATUS FAKE_NPC,{ OnPCLoginEvent: if (getgroupid() >= 2) { Query_SQL "SELECT DATE(DATE_ADD(`insert_on`, INTERVAL `days` DAY)), DATEDIFF(DATE_ADD(`insert_on`, INTERVAL `days` DAY), NOW()) FROM `viptable` WHERE `vipacc_id` = '"+GetCharID(3)+"'", [email protected]_date$, [email protected]_left; dispbottom "========================"; dispbottom "Account Status : VIP"; dispbottom "Expire Date : " + [email protected]_date$; dispbottom "Time left : " + [email protected]_left; dispbottom "========================"; end; } } ~Kenpachi
  7. Sorry dude, but I wont write a complete patch for the item options system that works with your emulator version. it's not just updating the clif.c/.h but also packets, the socket, macros and everything else related to items. I spent more than an hour trying to add that diff to your emulator version, but didn't even came close to something compilable... Again, sorry. ~Kenpachi
  8. Kenpachi

    Woe setter

    Hi. I see no problems. It should start WoE each friday at 14:45 and end it at 16:45. I'd use agitstart; and agitend; instead of the @commands, but that's up to you. ~Kenpachi
  9. Hi. Haven't tested it, but try ITEMLINK instaead of ITEM. (Source) It depends on the used client which one works. (Source) ~Kenpachi
  10. Hi. The actual problem is that you've changed the the data type of a parameter which is passes to the clif_add_random_options method. Thus you have to change the data type when calling clif_add_random_options, too. Double click each warning in VS to jump to the line where the data type mismatch was detected. You'll notice, that the method call tries to pass something like WBUFP(buf, 19) or WFIFOP(fd,21+offset) which both wont return an ItemInfo struct which clif_add_random_options expects to be passed. Now that you've found the faulty spots, have a look at the corresponding code parts in Hercules and change your code accordingly. Hope this helps. ~Kenpachi
  11. No Problem, dude. You really helped me. 😍 I think my question was answered completely now. Maybe you should consider to discuss Hercules' way of interppreting water cells with the dev team. (Refering to my last post.) *Marking your answer as solution.* ~Kenpachi
  12. Thanks a lot. That's something to work with. 😊 But this actually means, that *Athenas interpretation of water cells is far from official behavior. According to your code snippet every cell can be a water cell regardless of its type, but *Athena only accept type 3 or alternatively type 0 (cast to 3) if the conditions are fulfilled: // FROM map.c - map_readgat(struct map_data *m) if( type == 0 && water_height != NO_WATER && height > water_height ) type = 3; // Cell is 0 (walkable) but under water level, set to 3 (walkable water) And additionally I'm wondering about the difference in the water level check condition. According to your code snippet AEGIS checks if cell height is less than water level, while everyone else checks if cell height is greater than water level. This really confuses me. 😲 ~Kenpachi
  13. Okay, before reading your post I did some improvements to my code. At first I noticed that return 0 if no RSW file was found and then ignoring it was stupid, sind 0 is an assumable value. So I changed it to float.NaN which brought slightly different results: After this I thought about bad rounding of float values when comparing, so I changed the comparison to byte level and got really different results: So I'll stick to the byte level comparison, since this should be more accurate. Now that I've read your post I noticed, that AEGIS uses the 4th DWORD, which noone else does. Hercules uses the 1st DWORD: (Woops! Possible improvement detected. 😋) Let's compare those two: Okay, there's a huge difference. For a better overview only the AEGIS based results: Still not what one would expect, since type 3 should be water. Let's see what happens when checking for value is less than water level: Well, type 3 looks better now but overall it still looks bad. Let's include equality when comparing: Still... no perfection at all. 😥 My currently used algorithms: Any thoughts/suggestions? ~Kenpachi
  14. Hi there. Long time no see. 😊 I'm currently working on a small server/client application just as a finger exercise for me. Therefor I'm using RO files and stumbled over the .gat cell types and their relation with the water level in .rsw files. According to *Athena and some other projects there should be just a few possible types: Additionally I found different ways to check if a cell is under water or not: So I did a little testing a wrote a tool to collect all combinations of cell types and water level checks in every map. This is the result: What? Now I really got confused. Even if only the *Athena way (IsUnderWaterUpperLeft) to check cell types is payed attention to, there is a significant difference to what one would expect: See? Maybe I'm using wrong algorithms, but they seem to be correct: So could anybody please tell me, how AEGIS handles this? Maybe Hercules can profit by this, too. 🙄 ~Kenpachi
  15. Hi guys. ( Yes, I'm still alive. ) First of all: great idea, great work! This confused me, and so I checked the commit... Is it supposed to not include announce, mapannounce, areaaanounce, menu, dispbottom and probably some other string related commands? //EDIT: I put my hand up if you need a volunteer for a german translation. ~ Kenpachi
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.