Smoke

Hercules Battlegrounds

Recommended Posts

Very sad because this will be a great way to get more people into Herc.. rAthena has a stable version of rAmod (Herc don't) and this is not necessary in there and check it now the rA forum, very active with a great comunity.

 

Share this post


Link to post
Share on other sites

Hello @Smoke, congratulations on the work! 

Since the emulator has had a package update, some errors are affecting the build. If it's not uncomfortable, could you help us?

My emulator is from 11/16/2018, but I've updated it to the current date.

Share this post


Link to post
Share on other sites
On 28/11/2018 at 2:05 PM, M4karov said:

Hello @Smoke, congratulations on the work! 

Since the emulator has had a package update, some errors are affecting the build. If it's not uncomfortable, could you help us?

My emulator is from 11/16/2018, but I've updated it to the current date.

Hercules changed how Packets work on cliff.c

You should change hBG.c like this :
1) Import packets.h
 

#include "common/packets.h"

in places using "packet->len", change to "packets->db[cmd]"

clif->send(buf, packet->len, &sd->bl, BG_AREA_WOS);

change to:

clif->send(buf, packets->db[cmd], &sd->bl, BG_AREA_WOS);



They changed the "addflooritem" function, now you need to add 1 more parameter (bool) if you want to show drop effect:

count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4,true) != 0) ? 1 : 0;
--------------------------------------------------------------------/\  this


They also changed skill_fail, just add a 0 on end.

 

clif->skill_fail((*sd), *skill_id, USESKILL_FAIL_SKILLINTERVAL, 0, 0);
------------------------------------------------------------------/\this



This may fix your problems. 




*Edit 1:
Herc also changed how Mapcache works, so you'll have to rebuild your mapcache to include the maps "bat_a03, bat_a04..." that also doesn't exist on the mapcache.dat (used by rAthena too). I found the solution by adding the maps which herc BG copy to make their own battleground maps into data folder by extracting them from the data.grf file. Then, after rebuilding the mapcache using the new system, Herc BG is working pretty well.

Edited by iTRz

Share this post


Link to post
Share on other sites

@M4karov I already addressed. This plugin is no longer supported.

On 7/5/2018 at 6:34 PM, Myriad said:

No offence to the creator Smoke, as he did a great effort putting this all together, but there are outstanding issues which make it not possible to use in a production server.

Being curious, just did some more testing with it, and the guild system (I believe that's what causes it) actually creates this issue where sometimes the sword cursor doesn't appear (need to refresh to get it to show, seems random chance it actually appears), meaning your players would need to have /ns activated all the time to play. 

So please, any future posters - unless you know how to edit the plugin (and therefore source code) itself, don't download it.

And nobody request support as nobody is going to help you.

 

Share this post


Link to post
Share on other sites

Sorry guys, I have no time to continue the development of the project.

The reason I made it open source was to gain developer involvement in the project so it moves forward, but for some reason barely anyone contributes.

It is not a large-scale project as are others that I'm working on currently and I can only focus on one.

Also why was this moved from Plugin releases to the Script release section? This is primarily a plugin release.

Best regards~

Share this post


Link to post
Share on other sites

Anyone can help with this errors?

hBG.c: In function ‘atcommand_leader’:
hBG.c:2196:12: error: ‘hBGpl_sd’ undeclared (first use in this function)
  else if ((hBGpl_sd = getFromMSD(pl_sd, 0)) == NULL)
            ^
hBG.c:2196:12: note: each undeclared identifier is reported only once for each function it appears in
hBG.c:2181:31: warning: unused variable ‘hBGsd’ [-Wunused-variable]
  struct hBG_map_session_data *hBGsd = NULL;
                               ^
hBG.c: At top level:
hBG.c:3940:43: error: unknown type name ‘clr_type’
 int unit_free_pre(struct block_list **bl, clr_type *clrtype)
                                           ^
hBG.c: In function ‘clif_sendbgemblem_area_overloading’:
hBG.c:4195:28: warning: unused variable ‘packet’ [-Wunused-variable]
  const struct s_packet_db *packet = clif->packet(cmd);
                            ^
hBG.c: In function ‘clif_sendbgemblem_single_overloading’:
hBG.c:4210:28: warning: unused variable ‘packet’ [-Wunused-variable]
  const struct s_packet_db *packet = clif->packet(cmd);
                            ^
In file included from hBG.c:61:0:
hBG.c: In function ‘plugin_init’:
hBG.c:4585:26: error: ‘unit_free_pre’ undeclared (first use in this function)
   addHookPre(unit, free, unit_free_pre);
                          ^
../plugins/HPMHooking.h:49:57: note: in definition of macro ‘addHookPre’
   (void)((HPMHOOK_pre_ ## ifname ## _ ## funcname)0 == (hook)), \
                                                         ^
../plugins/HPMHooking.h:49:63: warning: left-hand operand of comma expression has no effect [-Wunused-value]
   (void)((HPMHOOK_pre_ ## ifname ## _ ## funcname)0 == (hook)), \
                                                               ^
hBG.c:4585:3: note: in expansion of macro ‘addHookPre’
   addHookPre(unit, free, unit_free_pre);
   ^
Makefile:105: recipe for target '../../plugins/hBG.so' failed


 

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...