Jump to content
  • 0
Dastgir

Need NoView Plugin Support

Question

Hello,

 

I have today released new plugin, namely NoView.

It adds command @noview to disable the headgear views for users (Upper/Mid/Lower headgear views)

 

Link: https://github.com/dastgirp/HPM-Plugins/blob/master/src/plugins/noview.c

Share this post


Link to post
Share on other sites

13 answers to this question

Recommended Posts

  • 0

At first, thanks for the plugin release,
but It's just me who get the const error?

 

Quote

noview.c: In function ‘clif_send_helper’:
noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0);
                                                 ^
noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0);
                                                  ^
noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0);
                                                  ^
noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0);
                                                   ^
noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0);
                                                    ^
noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0);
                                                     ^
noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0);
                                                     ^
noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0);
                                                      ^
noview.c: In function ‘clif_send_sub_hook’:
noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable]
  int bool_;
 


 

Share this post


Link to post
Share on other sites
  • 0
On 8/13/2020 at 2:13 PM, Dastgir said:

It adds command @noview to disable the headgear views for users

Aaand the next stuff. Don't know if this just me, but the command works for the whole server.
So... if anyone use the command, the whole server can't see headgears. xD

Share this post


Link to post
Share on other sites
  • 0
On 8/18/2020 at 4:47 PM, Zero Human said:

At first, thanks for the plugin release,
but It's just me who get the const error?

noview.c: In function ‘clif_send_helper’:
noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0);
                                                 ^
noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0);
                                                  ^
noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0);
                                                  ^
noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0);
                                                   ^
noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0);
                                                    ^
noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0);
                                                     ^
noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0);
                                                     ^
noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0);
                                                      ^
noview.c: In function ‘clif_send_sub_hook’:
noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable]
  int bool_;


 

I notice this error too (but in centos/linux only. On windows, its fine), but somehow I didn't experience that whole server noview. I'll try to test that very soon.

Share this post


Link to post
Share on other sites
  • 0

119994757_2183881825091092_8348352095742889442_n.png.dcb793656eb35b2b3ecc56f322422859.png

Quote

noview.c: In function ‘clif_send_helper’:
noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0);
                                                 ^
noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0);
                                                  ^
noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0);
                                                  ^
noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0);
                                                   ^
noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0);
                                                    ^
noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0);
                                                     ^
noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0);
                                                     ^
noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0);
                                                      ^
noview.c: In function ‘clif_send_sub_hook’:
noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable]
  int bool_;

Is this normal to receive this warning? And is there any way to get rid of this?

 

Edited by xJhay

Share this post


Link to post
Share on other sites
  • 0

hmm ........ already 2 people getting the same error message

I just tested on my test server, compile with visual studio 2019, no problem everything green though

noviewon.png

 

if you get this error does it means you also get disable view for whole server instead of individual player ?

Share this post


Link to post
Share on other sites
  • 0
6 hours ago, AnnieRuru said:

hmm ........ already 2 people getting the same error message

I just tested on my test server, compile with visual studio 2019, no problem everything green though

noviewon.png

 

if you get this error does it means you also get disable view for whole server instead of individual player ?

Hi mam annie. Sometimes, its happening and I'm not sure of that kind of behavior but the main thing is I kinda worried of those warning because it's too many and might cause of more exploits or something.

Share this post


Link to post
Share on other sites
  • 0
17 hours ago, xJhay said:

Hi mam annie. Sometimes, its happening and I'm not sure of that kind of behavior but the main thing is I kinda worried of those warning because it's too many and might cause of more exploits or something.

The error can ignore for now, but I will get it fixed soon.

If you could tell me the steps to reproduce, I will fix it, but without the steps to reproduce, it's hard for me to test as well.

Share this post


Link to post
Share on other sites
  • 0
8 hours ago, Dastgir said:

The error can ignore for now, but I will get it fixed soon.

If you could tell me the steps to reproduce, I will fix it, but without the steps to reproduce, it's hard for me to test as well.

Hello sir dastgir. I do nothing but to put the plugin and recompile it, then the warning shows up.

 

Edit: When I compile it to windows, its okay and it has no error shows. Only in CentOS.

image.png.d5c8b5e14f15c1ce3fa91d892a5ef6aa.png

Edited by xJhay
Edit: Adding additional info.

Share this post


Link to post
Share on other sites
  • 0
2 hours ago, xJhay said:

Hello sir dastgir. I do nothing but to put the plugin and recompile it, then the warning shows up.

 

Edit: When I compile it to windows, its okay and it has no error shows. Only in CentOS.

image.png.d5c8b5e14f15c1ce3fa91d892a5ef6aa.png

I am aware of this warning, for now it's safe to ignore, I was talking about the bug wherein whole server couldn't see hg, I want to know the steps to reproduce that bug

Share this post


Link to post
Share on other sites
  • 0
On 9/26/2020 at 7:04 AM, Dastgir said:

I am aware of this warning, for now it's safe to ignore, I was talking about the bug wherein whole server couldn't see hg, I want to know the steps to reproduce that bug

 1pff.png

 

same error as @Zero Human etc etc
I just recompile my server after dragging the files for the plugin.

Edited by Daraen

Share this post


Link to post
Share on other sites
  • 0
Posted (edited)

Here got same warning when compile first time.

if  compile again without (make clean) dont show this warnings.

Edited by brunosc

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.