Dastgir

Ultimate Guild Ranker

Recommended Posts

[Error]: script_rid2sd: fatal error ! player not attached![Debug]: Function: getcharid (1 parameter):[Debug]: Data: number value=2[Debug]: Source (NPC): UltimateRanker#00 (invisible/not on a map)

 

change this

 

donpcevent "UltimateRanker#00::OnEmpBreak";

to this

 

doevent "UltimateRanker#00::OnEmpBreak";

to get rid of this error

Edited by quesoph

Share this post


Link to post
Share on other sites

 

[Error]: script_rid2sd: fatal error ! player not attached![Debug]: Function: getcharid (1 parameter):[Debug]: Data: number value=2[Debug]: Source (NPC): UltimateRanker#00 (invisible/not on a map)

 

change this

 

donpcevent "UltimateRanker#00::OnEmpBreak";

to this

 

doevent "UltimateRanker#00::OnEmpBreak";

to get rid of this error

Seems like I bymistakely diffed a wrong folder....

Anyways,Uploaded a fixed version.

Share this post


Link to post
Share on other sites

very nice , thank you sir :)

 

Question :

 

Percentage Changes:AgitCount= 20%Emp Break = 50%Active Participants = 20%KDR = 10%

 

Can i change this to :

 

Percentage Changes:AgitCount= 20%Emp Break = 50%Active Participants = 10%KDR = 20%

 

From OnInit ?

Edited by Max

Share this post


Link to post
Share on other sites

very nice , thank you sir :)

 

Question :

 

Percentage Changes:AgitCount= 20%Emp Break = 50%Active Participants = 20%KDR = 10%

 

Can i change this to :

 

Percentage Changes:AgitCount= 20%Emp Break = 50%Active Participants = 10%KDR = 20%

 

From OnInit ?

Yes, that's the reason I have included those variables in OnInit:

You can change those to any values you want.

Share this post


Link to post
Share on other sites

Got this error

 

[SQL]: DB error - Table 'hercules.ugr_guild_infoV' doesn't exist[Debug]: at script.c:14613 - INSERT INTO `ugr_guild_infoV` (`date`,`HighEmpBreak`) VALUES (201403,1) ON DUPLICATE KEY UPDATE `HighEmpBreak`=1[Debug]: Source (NPC): UltimateGuildRanker at amatsu (128,161)

Share this post


Link to post
Share on other sites

^

create these tables

 

---- Table structure for table `ugr_guild_info`--CREATE TABLE IF NOT EXISTS `ugr_guild_info` (  `guild_id` mediumint(6) NOT NULL DEFAULT '0',  `breaks` smallint(5) NOT NULL DEFAULT '0',  `kills` smallint(5) NOT NULL DEFAULT '0',  `deaths` smallint(5) NOT NULL DEFAULT '0',  `APart` mediumint(6) NOT NULL DEFAULT '0',  `percent` SMALLINT(4) NOT NULL DEFAULT '0',  `date` MEDIUMINT(7) NOT NULL DEFAULT '0',  `claim` tinyint(1) NOT NULL DEFAULT '1',  UNIQUE KEY `guild_id` (`guild_id`,`date`)) ENGINE=MyISAM DEFAULT CHARSET=latin1;---- Table structure for table `ugr_guild_infov`--CREATE TABLE IF NOT EXISTS `ugr_guild_infov` (  `date` MEDIUMINT(7) NOT NULL DEFAULT '0',  `AgitCount` mediumint(6) NOT NULL DEFAULT '1',  `HighEmpBreak` MEDIUMINT(6) NOT NULL DEFAULT '0',  UNIQUE KEY `date` (`date`,`AgitCount`)) ENGINE=MyISAM DEFAULT CHARSET=latin1;

Share this post


Link to post
Share on other sites

^

create these tables

 

 

---- Table structure for table `ugr_guild_info`--CREATE TABLE IF NOT EXISTS `ugr_guild_info` (  `guild_id` mediumint(6) NOT NULL DEFAULT '0',  `breaks` smallint(5) NOT NULL DEFAULT '0',  `kills` smallint(5) NOT NULL DEFAULT '0',  `deaths` smallint(5) NOT NULL DEFAULT '0',  `APart` mediumint(6) NOT NULL DEFAULT '0',  `percent` SMALLINT(4) NOT NULL DEFAULT '0',  `date` MEDIUMINT(7) NOT NULL DEFAULT '0',  `claim` tinyint(1) NOT NULL DEFAULT '1',  UNIQUE KEY `guild_id` (`guild_id`,`date`)) ENGINE=MyISAM DEFAULT CHARSET=latin1;---- Table structure for table `ugr_guild_infov`--CREATE TABLE IF NOT EXISTS `ugr_guild_infov` (  `date` MEDIUMINT(7) NOT NULL DEFAULT '0',  `AgitCount` mediumint(6) NOT NULL DEFAULT '1',  `HighEmpBreak` MEDIUMINT(6) NOT NULL DEFAULT '0',  UNIQUE KEY `date` (`date`,`AgitCount`)) ENGINE=MyISAM DEFAULT CHARSET=latin1;

 

 

 

 

Yea i already run it on my sql, still getting that error.

 

 

Edited : FIXED. thanks to Dastgir

Edited by Dastgir

Share this post


Link to post
Share on other sites

1. Whenever I @agitstart & @agitstop and @reloadnpc this executes set $AgitCount, $AgitCount + 1;. and may high percentage / guild points bug.

 

2.

[SQL]: DB error - Column 'percent' cannot be null[Debug]: at c:testsrcmapscript.c:14582 - UPDATE `ugr_guild_info` SET `percent`=( ((1/3*100)*20/100)+((`kills`/(`deaths`+1)*100)*10/100)+((`breaks`/1*100)*50/100)+((`APart`/(select count(*) FROM `guild` WHERE `guild`.`guild_id`=`ugr_guild_info`.`guild_id`)*100)*20/100)) WHERE `date`=201403[Debug]: Source (NPC): UltimateGuildRanker at prontera (153,181)

break emperium and use @breakguild then check UGR npc.

 

 

These are the problems I've encountered so far.. ^^


 

Edited by quesoph

Share this post


Link to post
Share on other sites

1. Whenever I @agitstart & @agitstop and @reloadnpc this executes set $AgitCount, $AgitCount + 1;. and may high percentage / guild points bug.

 

2.

[SQL]: DB error - Column 'percent' cannot be null[Debug]: at c:testsrcmapscript.c:14582 - UPDATE `ugr_guild_info` SET `percent`=( ((1/3*100)*20/100)+((`kills`/(`deaths`+1)*100)*10/100)+((`breaks`/1*100)*50/100)+((`APart`/(select count(*) FROM `guild` WHERE `guild`.`guild_id`=`ugr_guild_info`.`guild_id`)*100)*20/100)) WHERE `date`=201403[Debug]: Source (NPC): UltimateGuildRanker at prontera (153,181)

break emperium and use @breakguild then check UGR npc.

 

 

These are the problems I've encountered so far.. ^^

 

 

1) & 2) I will fix it in next update. (you could have lowered the percent of agitcount too,  but anyways, included some options to prevent unnecessary increment of AgitCount)

Added a new configuration .Config_UGR[4](set seconds here), if WoE Starts again within x seconds, then AgitCount will not increase.

 

 

(you were using v1.0b, while v1.0c was out, anyways new version will be v1.0d, and will have these problems fixed.)

Edited by Dastgir Pojee

Share this post


Link to post
Share on other sites

(you were using v1.0b, while v1.0c was out, anyways new version will be v1.0d, and will have these problems fixed.)

 

lol I didn't notice that there was a new version. Thank you btw! :D

Share this post


Link to post
Share on other sites

@Suggestion

Use bc_self so that output will be clearer..

and

 

if ( getguildname( .guild_id[.i] ) == "null" ) requestguildinfo .guild_id[.i];

Other guild names become NULL when you restart your server.

 

 

   	 mes "Sending data...";        announce "Format: Data Based on "+gettime(5)+"Days/"+$AgitCount+" Castles",bc_self,0xff6622;        announce "[GuildName] - Breaks - Kills - Death - GuildPoints "+((getgmlevel()>=getvariableofnpc(.Config_UGR[4],"UltimateRanker#00"))?"- Active Partrticipant":"")+" ",bc_self,0xff6622;        announce "----------------------",bc_self,0xff6622;        for (.i=0; .i<getarraysize(.guild_id); .i++){        if ( getguildname( .guild_id[.i] ) == "null" ) requestguildinfo .guild_id[.i];            announce (.i+1) +". [ "+getguildname(.guild_id[.i])+" ] - "+.breaks[.i]+" - ^66D729"+.kills[.i]+" - "+.deaths[.i]+"0 - "+.percent[.i]+" "+((getgmlevel()>=getvariableofnpc(.Config_UGR[4],"UltimateRanker#00"))?"- "+.apart[.i]+"":"")+"",bc_self,0xff6622;        }        announce "----------------------",bc_self,0xff6622;

 

@question

 

What is this for?

((getgmlevel()>=getvariableofnpc(.Config_UGR[4],"UltimateRanker#00"))?" - Active Partrticipant":"")+" "

 

if gm level is greater than or equals 3600 show "- Active Partrticipant" ? correct me if i am wrong. :D

Edited by quesoph

Share this post


Link to post
Share on other sites

@Suggestion

Use bc_self so that output will be clearer..

and

 

if ( getguildname( .guild_id[.i] ) == "null" ) requestguildinfo .guild_id[.i];

Other guild names become NULL when you restart your server.

 

 

   	 mes "Sending data...";        announce "Format: Data Based on "+gettime(5)+"Days/"+$AgitCount+" Castles",bc_self,0xff6622;        announce "[GuildName] - Breaks - Kills - Death - GuildPoints "+((getgmlevel()>=getvariableofnpc(.Config_UGR[4],"UltimateRanker#00"))?"- Active Partrticipant":"")+" ",bc_self,0xff6622;        announce "----------------------",bc_self,0xff6622;        for (.i=0; .i<getarraysize(.guild_id); .i++){        if ( getguildname( .guild_id[.i] ) == "null" ) requestguildinfo .guild_id[.i];            announce (.i+1) +". [ "+getguildname(.guild_id[.i])+" ] - "+.breaks[.i]+" - ^66D729"+.kills[.i]+" - "+.deaths[.i]+"0 - "+.percent[.i]+" "+((getgmlevel()>=getvariableofnpc(.Config_UGR[4],"UltimateRanker#00"))?"- "+.apart[.i]+"":"")+"",bc_self,0xff6622;        }        announce "----------------------",bc_self,0xff6622;

 

@question

 

What is this for?

 

((getgmlevel()>=getvariableofnpc(.Config_UGR[4],"UltimateRanker#00"))?" - Active Partrticipant":"")+" "

 

 

if gm level is greater than or equals 3600 show "- Active Partrticipant" ? correct me if i am wrong. :D

Seems like i messed away the getgmlevel Part, First i implemented these, than after seeing your comment here, i used [4] for time, and it messed away.

 

 

Other guild names become NULL when you restart your server. 

Never experienced this, but yet, i will implement your way.

 

About bc_self,(I don't like announce, that's why i have chosen npc dialog...)

Share this post


Link to post
Share on other sites

is this fine?? 15g9xxy.jpg

when i try to check the "Previous Month Top 10 Guilds" that Warning & Debug appears... 

 

hmmm and if you're open for suggestion.. 

can you add a Reward when WOE Ends

is it possible?

Share this post


Link to post
Share on other sites

is this fine?? 15g9xxy.jpg

when i try to check the "Previous Month Top 10 Guilds" that Warning & Debug appears... 

 

hmmm and if you're open for suggestion.. 

can you add a Reward when WOE Ends

is it possible?

Fixed the warning,

 

Reward Claim by npc or auto? and reward given to GuildMaster or each member?

Share this post


Link to post
Share on other sites

Is this currently counting all player kills and not only the ones that happen in woe?

Not sure if this is meant to be a woe ranking or more of a general guild ranking, in which case you could have stuff like mvps killed by guild affect ranking too (suggestion)?

Share this post


Link to post
Share on other sites

Is this currently counting all player kills and not only the ones that happen in woe?

Not sure if this is meant to be a woe ranking or more of a general guild ranking, in which case you could have stuff like mvps killed by guild affect ranking too (suggestion)?

Its Guild Ranking, so all kills are currently counted..

Share this post


Link to post
Share on other sites

 

How can i make only 1st guild claim reward?

Its only 1st guild claim.(found any bugs  :huh: ?)

 

How can i disable my staff guilds from beeing displayed in the ranking? :|

Share this post


Link to post
Share on other sites

 

How about woe se castle count?

 

where should i add this : 

 

doevent "UltimateRanker#00::OnEmpBreak"; 

Below

 

OnStartArena: 

npc/guild2/agit_main_se.txt

 

 

 

I am using 1.1b and I am having a trouble with duplicate guild ids.

sorry for extremely late reply, what is trouble?

 

 

 

 

How can i make only 1st guild claim reward?

Its only 1st guild claim.(found any bugs  :huh: ?)

 

How can i disable my staff guilds from beeing displayed in the ranking? :|

I will update it to add exceptions

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...