Jump to content

Dark Theme was set as default for all members. Please report any issues here.

Dastgir

ItemDB can support items with > 32k id

Recommended Posts

So I just read the May Digest, and there's no word about this so I'm assuming it was never added. Is there any talk about it from the core devs though?

 

rAthena's already done it quite recently.

It is not yet added @ Hercules.

(Maybe i will make a pull request, so core dev can review it.)

Share this post


Link to post
Share on other sites

Already implemented in latest rev.?? Coz when I try changing #define MAX_ITEMDB 0x10000

I got this compile error. :(
 

itemdb.c: In function 'itemdb_validate_entry':
itemdb.c:1370: warning: comparison is always false due to limited range of data type


 

Edited by Hadeszeus

Share this post


Link to post
Share on other sites

Well , in case another unfortunate soul happens to come by this same mistake:


You can solve it by changing the actual SQL data save in :

src/char/char.c from short to ushort

Even if you already changed the definitions in src/map the emulator is apparently configured to send a short value regardless... which this change fixes

Well that's it , enjoy!

Edited by Shatter

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.