script_command adjustments

[GmOcean 92]

Well some may not consider this an overhaul, but really I think a few commands are in need of a small adjustment

Namely the following:

*getinventorylist;*getpartymember <party id>{,<type>};*getguildmember <guild id>{,<type>};*getmobdrops(<mob id>)

These 4 commands all having something in common.

1. They produce array's using $@variables. ( *getinventorylist being the exception using @variables ).

2. They all produce a variable that deals with their array size.

3. They don't erase that array.

 

What I'm suggesting is simple.

1. Produce .@(temp_scope) variables.

2. eliminate this variable entirely, or leave it for backwards compatibility.

3. Erase the array upon execution of command. This will allow the use of getarraysize(); for each of these commands, which imo should have been the norm.

 

These are just my thoughts on the matter. Anyone else feel the same way?

[Dastgir 1244]

Support for scope variable is good, but it surely will broke all scripts using those commands.

Though haruna would be able to comment if it's viable or not.

[GmOcean 92]

Yeah, I thought about the breaking of all other scripts using the commands, but I figured it'd fit right in along with other deprecated commands in that sense.

[Dastgir 1244]

Yeah, I thought about the breaking of all other scripts using the commands, but I figured it'd fit right in along with other deprecated commands in that sense.

Not exactly, since command is not depreciated, the server owner will eventually open thread here saying getpartynember not working(we can't check if they using old variable name), so maybe either

Add a optional arguments which accepts variable name, and data will be stored there.