Gm Not Authorized To Storage
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#1532
Status
Invalid
Severity
None
Started
Hercules Elf Bot
May 18, 2008 18:15
Last Post
Hercules Elf Bot
Apr 5, 2012 8:06
Confirmation
Hercules Elf Bot - May 18, 2008 18:15
Originally posted by [b]Yonimelavo[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1532
The function "storage_storageopen" at storage.c:
[codebox]
What the reason is for not to authorize a GM to put his items into the storage? Does exists any kind of exploit?
If not, this should be deleted:
Since, as I believe, this configuration option from "pc_can_give_items" was for disabling a GM giving items to another players (a trade, for example). But I don't know how a player could take any items from a GM storage :S.
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1532
The function "storage_storageopen" at storage.c:
[codebox]
CODE
int storage_storageopen(struct map_session_data *sd)
{
struct storage *stor;
nullpo_retr(0, sd);
if(sd->state.storage_flag)
return 1; //Already open?
if( !pc_can_give_items(pc_isGM(sd)) )
{ //check is this GM level is allowed to put items to storage
clif_displaymessage(sd->fd, msg_txt(246));
return 1;
}
if((stor = idb_get(storage_db,sd->status.account_id)) == NULL)
{ //Request storage.
intif_request_storage(sd->status.account_id);
return 2;
}
if (stor->storage_status)
return 1; //Already open/player already has it open...
stor->storage_status = 1;
sd->state.storage_flag = 1;
clif_storagelist(sd,stor);
clif_updatestorageamount(sd,stor);
return 0;
}
[/codebox]{
struct storage *stor;
nullpo_retr(0, sd);
if(sd->state.storage_flag)
return 1; //Already open?
if( !pc_can_give_items(pc_isGM(sd)) )
{ //check is this GM level is allowed to put items to storage
clif_displaymessage(sd->fd, msg_txt(246));
return 1;
}
if((stor = idb_get(storage_db,sd->status.account_id)) == NULL)
{ //Request storage.
intif_request_storage(sd->status.account_id);
return 2;
}
if (stor->storage_status)
return 1; //Already open/player already has it open...
stor->storage_status = 1;
sd->state.storage_flag = 1;
clif_storagelist(sd,stor);
clif_updatestorageamount(sd,stor);
return 0;
}
What the reason is for not to authorize a GM to put his items into the storage? Does exists any kind of exploit?
If not, this should be deleted:
CODE
if( !pc_can_give_items(pc_isGM(sd)) )
{ //check is this GM level is allowed to put items to storage
clif_displaymessage(sd->fd, msg_txt(246));
return 1;
}
{ //check is this GM level is allowed to put items to storage
clif_displaymessage(sd->fd, msg_txt(246));
return 1;
}
Since, as I believe, this configuration option from "pc_can_give_items" was for disabling a GM giving items to another players (a trade, for example). But I don't know how a player could take any items from a GM storage :S.
Hercules Elf Bot - Dec 17, 2011 5:29
Originally posted by [b]Ind[/b]
please post suggestions in the development forum. thanks
-- though I myself don't think there is any problem in letting gms use own storage =p
please post suggestions in the development forum. thanks
-- though I myself don't think there is any problem in letting gms use own storage =p