Issue information

Issue ID
#1688
Status
Fixed
Severity
Low
Started
Hercules Elf Bot
Jun 15, 2008 9:38
Last Post
Hercules Elf Bot
Nov 23, 2012 4:32
Confirmation
N/A

Hercules Elf Bot - Jun 15, 2008 9:38

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1688

There is a small user interaction issue when adding new maps.
In all places, eathena silently trims the user input and says that it succeeded.
This can cause confusion since the map name limit is 11 chars, which is way too little in some cases.

Particular case: mapcache builder.
CODE
strncpy(info.name, name, MAP_NAME_LENGTH);

Hercules Elf Bot - Nov 23, 2012 4:20

Originally posted by [b]mkbu95[/b]
Well this bug seems to be about warning the user, but also could be put in discussion the actual map name length.

Hercules Elf Bot - Nov 23, 2012 4:28

Originally posted by [b]MaminhA[/b]
May I suggest changing [CODE]
name > MAP_NAME_LENGHT
[/CODE] to [CODE]
sizeof(name) > MAP_NAME_LENGHT
[/CODE]?

Hercules Elf Bot - Nov 23, 2012 4:32

Originally posted by [b]mkbu95[/b]
Yeah I saw that.. oh boy