Highly Dangerous Main.sql Script
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#1714
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Jun 19, 2008 10:59
Last Post
Hercules Elf Bot
Jun 19, 2008 10:59
Confirmation
Hercules Elf Bot - Jun 19, 2008 10:59
Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1714
All queries in the main.sql script start with "DROP TABLE". I have seen multiple instances where unintentional use of this script caused the whole main database to be wiped, with no backup available.
In my opinion, these drop actions are completely unneccessary, since you can drop tables just by clicking on a few checkboxes in phpMyAdmin. And in a normal set-up scenario, there are no existing tables so the drop action will not do anything.
Therefore my proposal is to remove the "DROP TABLE" part, and change the query to "CREATE TABLE IF NOT EXISTS".
main.sql.diff ( 10.99K ) Number of downloads: 40
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1714
All queries in the main.sql script start with "DROP TABLE". I have seen multiple instances where unintentional use of this script caused the whole main database to be wiped, with no backup available.
In my opinion, these drop actions are completely unneccessary, since you can drop tables just by clicking on a few checkboxes in phpMyAdmin. And in a normal set-up scenario, there are no existing tables so the drop action will not do anything.
Therefore my proposal is to remove the "DROP TABLE" part, and change the query to "CREATE TABLE IF NOT EXISTS".