Issue information

Issue ID
#1734
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Jun 22, 2008 5:17
Last Post
Hercules Elf Bot
Feb 21, 2012 14:07
Confirmation
N/A

Hercules Elf Bot - Jun 22, 2008 5:17

Originally posted by [b]Inkfish[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1734

I report a bug here: http://www.eathena.ws/board/index.php?auto...mp;showbug=1725
The "OnMyMobDead" event wouldn't trigger if the mob was killed (including captured as a pet, @killmonster2, *killmonsterall)and never attacked.

and I said this:
[qoute]
I simply add this

else {
npc_event_do(md->npc_event);
}

So, whenever the mob die, the event triggers.
So comes the issue that almost all the event scripts that summon monsters eA now has need to add a check manually on wheher is playerattached to decide continue or end.
[/quote]

They accepted my code edit, but left the script side alone.

Now, such quests as thana_quest, the sign, and the like all have the same issue that as soom as the script runs killmonsterall, it triggers the event as well.
So it's dangerous when last player left the monster alive and logout, the next would go straight to success.
I suggest every OnMobEvent should add a 'if(playerattached)' check if neccessary, though I know it's a BIG BIG task...

Or the code should be edited in another way. Anyway, the script and the code should fit each other.