Issue information

Issue ID
#1766
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jun 24, 2008 15:16
Last Post
Hercules Elf Bot
Feb 21, 2012 14:36
Confirmation
N/A

Hercules Elf Bot - Jun 24, 2008 15:16

Originally posted by [b]Koca[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1766

npc/jobs/2-2/dancer.txt; line 480:
CODE
.
.
.
switch(rand(1,3)) {
mes "[Bijou]";
.
.
.



There's "case 1:" missing.

EDIT: Another thing in the same script, lines 295 and 296:
set .@size, (getarraysize(.@item)-1); <---- Returns "3" for array of 4.
Part of the condition of FOR loop: .@i < .@size <---- loops from 0 to 2 (lower than) - so there's no check for the last item of array.

And the last thing: around lines 280 ~ 310, where's item check and Zeny take, there's no item deleting. I suggest:
CODE
            for( set .@i,0; .@i <= .@size; set .@i,.@i+1 )
                            delitem.@item[.@i],.@count[.@i];



I hope that's all (IMG:style_emoticons/default/smile.gif)

This post has been edited by Koca: Jun 24 2008, 08:35 AM