Negative Damage Healing - Hercules bug tracker archive

Issue information

Issue ID

#1843

Status

Fixed

Severity

Medium

Started

Hercules Elf Bot

Jul 14, 2008 5:07

Last Post

Hercules Elf Bot

Jun 24, 2012 0:17

Confirmation

N/A

Hercules Elf Bot - Jul 14, 2008 5:07

Originally posted by [b]Brainstorm[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1843

CODE

int battle_calc_damage(struct block_list *src,struct block_list *bl,int damage,int div_,int skill_num,int skill_lv,int flag)
{
    struct map_session_data *sd = NULL;
    struct status_change *sc;
    struct status_change_entry *sce;

    nullpo_retr(0, bl);

    if (!damage)
        return 0;

This was introduced by skotlex a long time ago, to fix something regarding attributes, no idea what it was really, need to review the changelog.
But this causes negative damage by element to actually heal the enemy, such as Storm Gust heal Garm. Poison attacks heal evildruid-wearers and so on.
It was tested that on aegis, you dont get any heal if your armor element reduced the damage to 0.

Hercules Elf Bot - Dec 17, 2011 4:57

Originally posted by [b]Ind[/b]
Need confirmation / source. quoting umage in the original bug
[quote]
I suggested a Wizard test, stormgust + lvl3 water mob ([url="http://rode.doddlercon.com/db/monster/view.php?update=3&monster=1776"]Siroma[/url] or even [url="http://rode.doddlercon.com/db/monster/view.php?update=3&monster=1161"]Plankton[/url]), damage the mob, sense it, cast spell, sense it again, compare values.[/quote]

Hercules Elf Bot - May 27, 2012 22:12

Originally posted by [b]MarkZD[/b]
I remember when I played in a 999 lv server, if you deal damage above the defined player.conf "max_hp"(it was 21kk something), it'll heal rather than damaging.

Hercules Elf Bot - Jun 24, 2012 0:17

Originally posted by [b]Ind[/b]
this was fixed some time ago. i tried to mimic the behavior in rathena and official server and both are the same -- you can't damage/heal garm for example with storm gust. confirmed with sense.