Issue information

Issue ID
#1933
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jul 27, 2008 21:46
Last Post
Hercules Elf Bot
Mar 5, 2012 8:51
Confirmation
N/A

Hercules Elf Bot - Jul 27, 2008 21:46

Originally posted by [b]timexy[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1933

I was making some modifications to the Create Essence/Dismantle Stone NPC in Umbala as some players asked me, and I bumped into this portion of the script code:
CODE
else if (.@shaman_p >= 4 && .@shaman_p == 6) {
    getitem 990,7; //Boody_Red
}

Maybe I misunderstood the script, but shouldn't it be "(.@shaman_p >= 4 && .@shaman_p <= 6)" os simple "(.@shaman_p == 6)"? For the Crystal Blue portion of the script it is using "(.@shaman_p >= 4 && .@shaman_p <= 6)" and the Wind Of Verdure portion is using the same as Boody Red.

And, at the Yellow Live portion we have a "else if (.@shaman_p >= 3 || .@shaman_p <= 4)", which is strange because if the rand return a 5, it will do sequence inside this IF instead the ELSE below it, turning it useless.

Oh, the script is at trunk/npc/quests/quests_umbala.txt, starting at line 775.