Bad Usage Of Pc_isgm() Function

Originally posted by [b]Splintter[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2034

Ok, i was looking at sources and i'm see how the devs is bad using the pc_isGM() function.

Let me start:

We have a config named "lowest_gm_level" that determine the lowest level to be considered a GM, oh yes, but some important functions didnt check this. Like the bug reported that i made about party trust, it uses pc_isGM() to check, but didnt compare with lowest_gm_level. I'm not the only that use GM level 1~5 to VIP, Helpers, and stuff, but this players get affected by some settings.

I can edit the sources and compile it checking pc_isGM(sd) >= lowest_gm_level, but some people do not.


Please consider it.

[quote name='theultramage']Which important functions don't check this?[/quote]

[quote name='Splintter']Well, i'm not at my house that have C++ now.

But i remember two things:

clif_selllist have something checking pc_isGM()

and like i said, the party new option to deny GM & Player party doesnt check this.

Sorry if i ofended someone saying "devs is bad using", i was just trying to say that this need to be checked on functions that use pc_isGM();[/quote]

[quote name='theultramage']Yeah, but I/we don't have a list of all the places that would need such changes and making one would be time-consuming.
You on the other hand have already done this, so it would be nice of you if you provided such a list - to limit the time I/we have to waste before actually doing any real fixing.[/quote]