Issue information

Issue ID
#2195
Status
Fixed
Severity
Critical
Started
Hercules Elf Bot
Sep 7, 2008 17:16
Last Post
Hercules Elf Bot
Sep 7, 2008 17:16
Confirmation
N/A

Hercules Elf Bot - Sep 7, 2008 17:16

Originally posted by [b]xilehack[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2195

hi there,

there's a crash relation to guilds.

what do you need for information? I could provide a repro, but i don't want to post in public.

dump is coming i just reported the repro steps to zephyrus

can't add dump but a screenshot.
so, i hope zephrys will post the dump or is able to fix it.

since it crashes (IMG:style_emoticons/default/tongue.gif)


umh no new infos? (IMG:style_emoticons/default/tongue.gif)

well here a piece of code:

in storage.c - Stable 13139 [TXT; working on SQL, too]

CODE
int storage_guild_storageadd(struct map_session_data* sd, int index, int amount)
{
    struct guild_storage *stor;

    nullpo_retr(0, sd);
    nullpo_retr(0, stor=guild2storage2(sd->status.guild_id));
        
    if (!stor->storage_status || stor->storage_amount > MAX_GUILD_STORAGE)
        return 0;
    
    if(index<0 || index>=MAX_INVENTORY)
        return 0;

    if(sd->status.inventory[index].nameid <= 0)
        return 0;
    
    if(amount < 1 || amount > sd->status.inventory[index].amount)
        return 0;

//    log_tostorage(sd, index, 1);
    if(guild_storage_additem(sd,stor,&sd->status.inventory[index],amount)==0)
        pc_delitem(sd,index,amount,0);

    return 1;
}


This post has been edited by xilehack: Sep 7 2008, 05:48 PM
Attached thumbnail(s)
Attached Image