Issue information

Issue ID
#2222
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Sep 13, 2008 5:25
Last Post
Ind
Jul 29, 2013 17:06
Confirmation
N/A

Hercules Elf Bot - Sep 13, 2008 5:25

Originally posted by [b]Inkfish[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2222

1. Well, while I was merging the mercenary code myself, I noticed that we add 'src = battle_get_master(src); // Maybe Player Summon' in pc_dead() so that when a player summoned monster killed a player, the OnPCKill event would trigger. To keep the consistency, shouldn't we add 'sd = map_id2sd((((TBL_MOB*)src)->master_id))' in mob_dead() too?

2. in mob_dead there is :

if( sd && sd->md && src && src->type != BL_HOM )
mercenary_kills(sd->md);

I don't quite get it, why it's 'src->type != BL_HOM' rather than 'src->type == BL_MER'

and script command 'killmonster' seems to work on adding mercenary's kill counts.

This post has been edited by Inkfish: Sep 13 2008, 01:18 AM

Ind - Jul 29, 2013 17:06

this has since been fixed