Too many "hardcoded" messages - Hercules bug tracker archive

Issue information

Issue ID

#2265

Status

Confirmed

Severity

None

Started

Hercules Elf Bot

Sep 24, 2008 11:13

Last Post

Hercules Elf Bot

Mar 17, 2012 19:50

Confirmation

Yes (2)

No (0)

Hercules Elf Bot - Sep 24, 2008 11:13

Originally posted by [b]Splintter[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2265

Well, Just poiting here that are too many messages that are hardcoded on the sources, and not using the msg_txt(number). I do sugest spend some time organizating this, it'll help developing on future.

When i have time i can create a diff with this, but i'll do it on my way, and not using the correct numbers maybe... so i'm posting it here to see if any dev can do this task (reorganization of msg_txt).

Hercules Elf Bot - Mar 13, 2012 19:38

Originally posted by [b]Gepard[/b]
[bug:5440] has been marked as a duplicate of this bug.

Hercules Elf Bot - Mar 14, 2012 4:19

Originally posted by [b]Protimus[/b]
I think it's not necessary.

I've done a quick search and does not have many hardcoded messages, it seems was made an update, because the report is of 2008.

This post has been edited by Protimus on Mar 15, 2012 17:11

Hercules Elf Bot - Mar 15, 2012 0:06

Originally posted by [b]SkzBR[/b]
Here is my patch to remove 90% of unofficial messages on official features. It cleanups the gameplay, and also turn easy using rAthena as a international emulator.

Thanks,
SkzBR.

Hercules Elf Bot - Mar 17, 2012 19:50

Originally posted by [b]Ind[/b]
[quote name='SkzBR' timestamp='1331770019' post='7580']
Here is my patch to remove 90% of unofficial messages on official features. It cleanups the gameplay, and also turn easy using rAthena as a international emulator.Thanks,SkzBR.
[/quote]
I appreciate your interest in contributing. I do believe however that removing these messages will reduce player-friendlyness, leaving the user to wonder in these scenarios why the feature he is attempting to use results in no action.