Mail attachments bug (possible loss of items)
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#2307
Status
Fixed
Severity
High
Started
Hercules Elf Bot
Oct 5, 2008 4:14
Last Post
Hercules Elf Bot
Nov 23, 2012 15:59
Confirmation
Hercules Elf Bot - Oct 5, 2008 4:14
Originally posted by [b]Gepard[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2307
Goes like this:
1. Open your mailbox. Open a mail with attachment.
2. Make map-server disconnect from char-server.
3. Request your attachment. Because there is no char server you won't get the item, but attachment will be removed from mapserver memory.
4. It is now impossible to delete the mail, so it's time to make map-server reconnect to char-server.
5. Now delete the mail. Because that is the mapserver that checks for attachment (and it thinks there is no attachment), the request is processed even though you didn't get the items. Mail is removed, attachment is lost. Players cry :cry:
I'm not sure how to fix it. Some ideas are: reload all mails when char and map reconnect, check for attachment on char-server not only map-server, don't delete attachment on map-server if there is no char-server.
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2307
Goes like this:
1. Open your mailbox. Open a mail with attachment.
2. Make map-server disconnect from char-server.
3. Request your attachment. Because there is no char server you won't get the item, but attachment will be removed from mapserver memory.
4. It is now impossible to delete the mail, so it's time to make map-server reconnect to char-server.
5. Now delete the mail. Because that is the mapserver that checks for attachment (and it thinks there is no attachment), the request is processed even though you didn't get the items. Mail is removed, attachment is lost. Players cry :cry:
I'm not sure how to fix it. Some ideas are: reload all mails when char and map reconnect, check for attachment on char-server not only map-server, don't delete attachment on map-server if there is no char-server.
This post has been edited by Brian on Nov 23, 2012 16:13
Hercules Elf Bot - Nov 23, 2012 3:59
Originally posted by [b]malufett[/b]
[quote]I'm not sure how to fix it. Some ideas are: reload all mails when char and map reconnect, check for attachment on char-server not only map-server, don't delete attachment on map-server if there is no char-server.[/quote]
hmm..what if don't process the transaction until char server is available..and let the user try again..
[quote]I'm not sure how to fix it. Some ideas are: reload all mails when char and map reconnect, check for attachment on char-server not only map-server, don't delete attachment on map-server if there is no char-server.[/quote]
hmm..what if don't process the transaction until char server is available..and let the user try again..
Hercules Elf Bot - Nov 23, 2012 4:10
Originally posted by [b]mkbu95[/b]
I'd go for ultramage suggestion, chrif_isconnected on it.
I'd go for ultramage suggestion, chrif_isconnected on it.
Hercules Elf Bot - Nov 23, 2012 4:23
Originally posted by [b]malufett[/b]
[quote]I'd go for ultramage suggestion, chrif_isconnected on it.[/quote]
hahaha..I didn't read the Ultramage post a while ago..anyway same idea..so +1
[quote]I'd go for ultramage suggestion, chrif_isconnected on it.[/quote]
hahaha..I didn't read the Ultramage post a while ago..anyway same idea..so +1
Hercules Elf Bot - Nov 23, 2012 15:59
Originally posted by [b]mkbu95[/b]
Fixed in [rev=16953].
Fixed in [rev=16953].