Issue information

Issue ID
#2349
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Oct 14, 2008 9:43
Last Post
Hercules Elf Bot
Mar 5, 2012 9:12
Confirmation
N/A

Hercules Elf Bot - Oct 14, 2008 9:43

Originally posted by [b]Perceval[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2349

Bug in 3rd Seal Quest: The announcement "The 3rd Seal of [Brisingamen] has been released" appears each time someone completes the 3rd Seal quest.

CODE
                     if ($God3 == 50) {
                         announce "The 3rd Seal of [Brisingamen] has appeared.",bc_all;
                     }
                     else if ($God3 == 100) {                
                         if ($God1 == 100 && $God2 == 100 && $God3 == 100 && $God4 == 100) {
                             announce "Four seals have been released at the same time with the seal of [Brisingamen].",bc_all;
                         }
                     }
                     else {
                         announce "The 3rd seal of [Brisingamen] has been released.",bc_all;
                     }



It should be:

CODE
                     if ($God3 == 50) {
                         announce "The 3rd Seal of [Brisingamen] has appeared.",bc_all;
                     }
                     else if ($God1 > 99 && $God2 > 99 && $God3 > 99 && $God4 > 99) {
                             announce "Four seals have been released at the same time with the seal of [Brisingamen].",bc_all;
                     }
                     else if ($God3 > 99) {
                         announce "The 3rd seal of [Brisingamen] has been released.",bc_all;
                     }



Bug in 4th Seal Quest: Only non-reborn classes will receive the weapon for their class, reborn-classes will all receive random weapons.
CODE
                     set .@gift,0;  
                     if (BaseClass == Job_Knight) {  
                         set .@gift,1;       }  
                     else if (BaseClass == Job_Priest) {  
                         set .@gift,2;       }  
                     else if (BaseClass == Job_Wizard){  
                         set .@gift,3;       }  
                     else if (BaseClass == Job_Blacksmith){  
                         set .@gift,4;       }  
                     else if (BaseClass == Job_hunter){  
                         set .@gift,5;       }  
                     else if (BaseClass == Job_Assassin){  
                         set .@gift,6;       }  
                     else if(BaseClass == Job_Crusader){  
                         set .@gift,7;       }  
                     else if (BaseClass == Job_Monk){  
                         set .@gift,8;       }  
                     else if (BaseClass == Job_Sage){  
                         set .@gift,9;       }  
                     else if (BaseClass == Job_Alchemist){  
                         set .@gift,10;       }  
                     else if (BaseClass == Job_Rogue){  
                         set .@gift,11;       }  
                     else if (BaseClass == Job_Bard){  
                         set .@gift,12;       }  
                     else if(BaseClass == Job_Hunter){  
                         set .@gift,13;       }  
                     else {   set .@gift,rand(1,13);  }



As you can see, the scripts only considers non-reborn classes. The correct script should be however:


CODE
                   if (Class == Job_Knight || Class == Job_Lord_Knight) set @gift,1;  
                   if (Class == Job_Priest || Class == Job_High_Priest) set @gift,2;  
                   if (Class == Job_Wizard || Class == Job_High_Wizard) set @gift,3;  
                   if (Class == Job_Blacksmith || Class == Job_Whitesmith) set @gift,4;  
                   if (Class == Job_Hunter || Class == Job_Sniper) set @gift,5;  
                   if (Class == Job_Assassin || Class == Job_Assassin_Cross) set @gift,6;  
                   if (Class == Job_Crusader || Class == Job_Paladin) set @gift,7;  
                   if (Class == Job_Monk || Class == Job_Champion) set @gift,8;  
                   if (Class == Job_Sage || Class == Job_Professor) set @gift,9;  
                   if (Class == Job_Alchemist || Class == Job_Creator) set @gift,10;  
                   if (Class == Job_Rogue || Class == Job_Stalker) set @gift,11;  
                   if (Class == Job_Bard || Class == Job_Clown) set @gift,12;  
                   if (Class == Job_Dancer || Class == Job_Gypsy) set @gift,13;
                    else {  
                         set .@gift,rand(1,13);  
                     }


This post has been edited by Perceval: Oct 14 2008, 02:45 AM