Issue information

Issue ID
#2615
Status
Fixed
Severity
Low
Started
Hercules Elf Bot
Jan 1, 2009 7:51
Last Post
Hercules Elf Bot
Mar 5, 2012 15:53
Confirmation
Yes (1)
No (0)

Hercules Elf Bot - Jan 1, 2009 7:51

Originally posted by [b]BrianL[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2615

1. After char command functionality was built into atcommands, some char commands now have lower levels.
(since the default [url="http://svn.eathena.ws/svn/ea/trunk/conf/atcommand_athena.conf"]atcommand_athena.conf[/url] has the [b]same level[/b] for both @ and #)

Was it intentional?
Here's a diff with the levels adjusted to how they were in [url="https://rathena.svn.sourceforge.net/svnroot/rathena/!svn/bc/13402/trunk/conf/charcommand_athena.conf"]charcommand_athena.conf[/url] before r13403:
[url="http://www.eathena.ws/board/index.php?act=attach&type=post&id=2344"](IMG:[/url][url="http://www.eathena.ws/board/style_images/ip.boardpr/folder_mime_types/txt.gif"]http://www.eathena.ws/board/style_images/ip.boardpr/folder_mime_types/txt.gif[/url]) cmd_lower.diff (4.96 K)

2. Also, some commands don't really make sense to be run as remote char commands, so should the defaults be set to 100?
Ex: request, npctalk, gvgon/off, pvpon/off, allowks, agitstart/end, agitstart2/end2, (un)block, (un)ban, (un)jail, hidenpc, shownpc, loadnpc, unloadnpc, npcmove, and a lot of the level 99 commands.
[url="http://www.eathena.ws/board/index.php?act=attach&type=post&id=2346"](IMG:[/url][url="http://www.eathena.ws/board/style_images/ip.boardpr/folder_mime_types/txt.gif"]http://www.eathena.ws/board/style_images/ip.boardpr/folder_mime_types/txt.gif[/url]) cmd_disable.diff (9.73 K)


[s]3. [url="http://svn.eathena.ws/svn/ea/trunk/conf/atcommand_athena.conf"]atcommand_athena.conf[/url] Line 643 should be [b]agitend[color=#FF0000]2[/color]:[/b][/s] Fixed in r[url="http://svn.eathena.ws/bugs/changeset/13444/trunk/conf/atcommand_athena.conf"]13444[/url]
CODE
// WoE 2 start/stop commands
agitstart2: 60,100
agitend: 60,100


This post has been edited by [b]BrianL[/b]: Apr 2 2009, 01:18 PM

This post has been edited by Brian on Dec 12, 2011 2:48

Hercules Elf Bot - Dec 12, 2011 3:09

Originally posted by [b]Brian[/b]
Updating status to: [b]Fixed[/b] in [rev=15071].