Issue information

Issue ID
#2627
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jan 4, 2009 5:12
Last Post
Hercules Elf Bot
Mar 5, 2012 9:29
Confirmation
N/A

Hercules Elf Bot - Jan 4, 2009 5:12

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2627

In the High Priest Zhed#rachel npc, there is a mistake in its structure.

The whole npc consists of a chain of if-else-if blocks (containing various cases), and a final else block in the end that contains a generic response. Well, more precisely, it ought to be like that, but on line 5468 there's a missing 'else' in front of the if, producing a separate if-else chain.
CODE
    if (MISC_QUEST & 8192) {
        // Start Veins "Thor Volcano Base" Quest Addition
...
    // End Veins "Thor Volcano Base" Quest Addition.
    }
    else {
        cutin "ra_gman",2;
        mes "[High Priest Zhed]";
        mes "May Freya be with you.";
    }
Issue introduced in r13249, where L0ne_W0lf changed the order of if-else blocks (previously, the MISC_QUEST part was at the beginning, now it's not).

This mistake causes leakage of the generic greeting into various parts of the rachel sanctuary quest, with no next; to separate it. That's how I noticed. To fix, I believe just adding the missing 'else' in there should do the trick.