Issue information

Issue ID
#2752
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Feb 7, 2009 7:07
Last Post
Hercules Elf Bot
Feb 7, 2009 7:07
Confirmation
N/A

Hercules Elf Bot - Feb 7, 2009 7:07

Originally posted by [b]Splintter[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2752

party.c code:

CODE
int party_invite(struct map_session_data *sd,struct map_session_data *tsd)
{
    struct party_data *p=party_search(sd->status.party_id);
    int i,flag=0;
    
    nullpo_retr(0, sd);


See?

You're getting sd->status.party_id before checking if this is a null pointer or not.

Suggestion:
CODE
int party_invite(struct map_session_data *sd,struct map_session_data *tsd)
{
    struct party_data *p=NULL;
    int i,flag=0;
    
    nullpo_retr(0, sd);
    p = party_search(sd->status.party_id);


Thank you

PS: Fast report, sorry for typos.

This post has been edited by Splintter: Feb 6 2009, 11:07 PM