Issue information

Issue ID
#2857
Status
Confirmed
Severity
None
Started
Hercules Elf Bot
Mar 12, 2009 14:36
Last Post
Hercules Elf Bot
Mar 12, 2009 14:36
Confirmation
N/A

Hercules Elf Bot - Mar 12, 2009 14:36

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2857

In an unrelated bugreport, I noticed the Turtle General Card's code cotains:
CODE
{ bonus2 bAddRace,RC_NonBoss,20; bonus2 bAddRace,RC_Boss,20; bonus2 bAddRace2,5,20;
That third part struck me kind of odd, so I investigated a bit. It turn out that's supposed to be "guardians".

This is how the original item script looks like:
CODE
    event OnStartEquip:
        ClassAddDamage 0 Target 20
        ClassAddDamage 1 Target 20
        ClassAddDamage 2 Target 20
See here that there is an independent notion of a monster "Class".
CODE
declare ClassAddDamage nnn ENUM++    // 상대의 클래스에 따라 데미지를 증가.    [0: 일반, 1: 보스, 2: 가디언]
declare ClassAddDamage nnn ENUM++    // relative to the class to increase the damage. [0: normal, 1: Boss, 2: Guardian]

So there is a separate attribute on each monster, categorizing it as either non-boss, boss, or guardian. Notice that in this system, guardians are neither bosses nor non-bosses.

Now come in eAthena. Whoever implemented support for this item bonus failed at requirements engineering. In eA, this "Class" concept got merged into the "Race" concept.
CODE
enum {
    RC_FORMLESS=0,
    RC_UNDEAD,
    RC_BRUTE,
    RC_PLANT,
    RC_INSECT,
    RC_FISH,
    RC_DEMON,
    RC_DEMIHUMAN,
    RC_ANGEL,
    RC_DRAGON,

    RC_BOSS,
    RC_NONBOSS,
    RC_NONDEMIHUMAN,
As you can see here, apart from the basic 10 races, the whole 'class' thing is hacked into the same structure. Looking at jAthena's itemdb, we see that the idea of boss/nonboss race came from there. The RC_NONDEMIHUMAN idea is a further perversion of the original race concept, added in a fairly recent eA update.

The whole concept of a 'boss' race was a mistake. On Aegis it's a completely separate attribute with separate logic and bonuses. That's why, for example, guardians are not affected by Knight_Of_Abyss card, nor have any interaction with Alice_Card. On eAthena, TG and AK cards actually increase damage against guardians, and, depending on the setup, also on the Emperium.