Issue information

Issue ID
#290
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Oct 24, 2007 13:51
Last Post
Hercules Elf Bot
Oct 24, 2007 13:51
Confirmation
N/A

Hercules Elf Bot - Oct 24, 2007 13:51

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=290

While inspecting the mail code and testing it, few things didn't seem alright to me...

1. if (rd && rd == sd) {
clif_Mail_send(fd, 1);
If you try to send a mail to yourself, the client displays "You have failed to send a message. Recipient does not exist."
(wrong error code?)

2. A new function, nick2sd_nocase was added to do pure case-sensitive name comparison. Is it actually neccessary?

3. There's code that seems to set the 'read' flag back to 0 if it was 1 and you read a message. Is that intended?