Issue information

Issue ID
#2993
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Apr 20, 2009 13:29
Last Post
Hercules Elf Bot
Apr 4, 2012 8:52
Confirmation
N/A

Hercules Elf Bot - Apr 20, 2009 13:29

Originally posted by [b]vhx[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=2993

Forgive me if this is incorrect, but this area in battle.c controls the PK mode damage reductions:
CODE
    if (battle_config.pk_mode && sd && bl->type == BL_PC && damage)
      {
        if (flag & BF_SKILL) { //Skills get a different reduction than non-skills. [Skotlex]
            if (flag&BF_WEAPON)
                damage = damage * battle_config.pk_weapon_damage_rate/100;
            if (flag&BF_MAGIC)
                damage = damage * battle_config.pk_magic_damage_rate/100;
            if (flag&BF_MISC)
                damage = damage * battle_config.pk_misc_damage_rate/100;
        } else { //Normal attacks get reductions based on range.
            if (flag & BF_SHORT)
                damage = damage * battle_config.pk_short_damage_rate/100;
            if (flag & BF_LONG)
                damage = damage * battle_config.pk_long_damage_rate/100;
        }
        if(!damage) damage  = 1;
    }


This gives a direct damage penalty to players from other players. However there are also WoE damage modifiers on by default somewhere else in the code. Since the above code specifies all damage, shouldn't there be an exception to WoE maps so the damage isn't adjusted twice?

This post has been edited by vhx: Apr 20 2009, 06:32 AM

Hercules Elf Bot - Dec 9, 2011 4:58

Originally posted by [b]Ind[/b]
Confirmed that it falls in both restrictions.

Hercules Elf Bot - Dec 9, 2011 5:02

Originally posted by [b]Ind[/b]
Fixed in [rev=15048]