'skill_unit_timer' weird behavior

Originally posted by [b]Inkfish[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3054

I was working on GX, and I set its interval to 300ms(which used to be 400), and total duration is 900ms. so it supposed to have 3 hits, but I get 4.

The reason might be, in function skill_unit_timer_sub:
1. The 'tick' passed by former function is up to 20~50ms delayed, comparing with gettick();
2. We check if the unit is expired AFTER processed it.

I wonder why it's coded this way.
Can we just use gettick()?( probably not )
or Can we check if it's expired first, then process the unit?

I tested, both way can solve the problem. I'm just not sure if it'll cause any new problems. But the latter solution sounds reasonable to me.

This post has been edited by Inkfish: May 6 2009, 09:44 AM