Originally posted by [b]Jobbie[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3057
As I searched around the source code regarding skills implementation I found out this issue about Magnum break which is declared twice.
I mean with this is that when the skill initiates the damage to become fire element the code was implemented twice.
I found out in skill_castend_damage_id()
CODE
if( skillid == SM_MAGNUM || skillid == MS_MAGNUM )
{ // Initiate 10% of your damage becomes fire element.
sc_start4(src,SC_WATK_ELEMENT,100,3,20,0,0,skill_get_time2(skillid, skilllv));
if( sd )
skill_blockpc_start(sd, skillid, skill_get_time(skillid, skilllv));
if( bl->type == BL_MER )
skill_blockmerc_start((TBL_MER*)bl, skillid, skill_get_time(skillid, skilllv));
}
and I found out in skill_castend_nodamage_id()
CODE
sc_start4(src,SC_WATK_ELEMENT,100,3,20,0,0,skill_get_time2(skillid, skilllv));
if (sd) skill_blockpc_start (sd, skillid, skill_get_time(skillid, skilllv));
break;
As I observed, the implementation is both the same. So why not only declare in one area that the skill calls its function.
Any feedback with this report? I was thinking this is a duplicate implementation. (IMG:
style_emoticons/default/smile.gif)