JOB_Battle_Manual
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#3177
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jun 3, 2009 21:55
Last Post
Hercules Elf Bot
Mar 5, 2012 14:13
Confirmation
Hercules Elf Bot - Jun 3, 2009 21:55
Originally posted by [b]Jobbie[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3177
We know that battle manual will boost your EXP for its corresponding rate in a period of time and battle manual will boost both BExp and JExp.
But the item JOB_Battle_Manual exist which will only boost your JExp. The problem is that, this item uses SC_EXPBOOST which has been used by Battle Manual items. So meaning if the JOB_Battle_Manual uses that sc it means that it will both boost BExp and JExp and it must not be like that.
The official description of it
Here is a fix that can be used.
In the source I added pc_calcexp_job which is same to pc_calcexp. But pc_calcexp_job will only returns Job exp bonuses.
Added also a new SC of SC_JEXPBOOST to separate the SC type used to JOB_Battle_Manual.
So this would be the item_db look like.
About its SI in code I have finished, I used SI_CASH_PLUSONLYJOBEXP which I think its better because only Job exp will be boost. And when you used it there is a dispbottom 'Job exp... something ' that will notify you..
But right now official servers uses still SI_EXPBOOST. But for me its better to use the other SI which I think the official one.
Fix Code UPDATED. Try more cleaner
JobManual_function.patch ( 4.29K ) Number of downloads: 11
NOTE: The code inside the diff is fully tested and 100% working.
Hoping for devs reply of this bug report and included the fix on it. (IMG:style_emoticons/default/biggrin.gif)
This post has been edited by GMJobbie: Jun 4 2009, 07:30 PM
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3177
We know that battle manual will boost your EXP for its corresponding rate in a period of time and battle manual will boost both BExp and JExp.
But the item JOB_Battle_Manual exist which will only boost your JExp. The problem is that, this item uses SC_EXPBOOST which has been used by Battle Manual items. So meaning if the JOB_Battle_Manual uses that sc it means that it will both boost BExp and JExp and it must not be like that.
The official description of it
CODE
14592#
One of the best manual in the manual field! People said it broke new battle manual ground.
^000088Job Exp rate is increased to 50% for 30 minutes.^000000
^ffffff_^000000
Weight : ^7777771^000000
#
One of the best manual in the manual field! People said it broke new battle manual ground.
^000088Job Exp rate is increased to 50% for 30 minutes.^000000
^ffffff_^000000
Weight : ^7777771^000000
#
Here is a fix that can be used.
In the source I added pc_calcexp_job which is same to pc_calcexp. But pc_calcexp_job will only returns Job exp bonuses.
Added also a new SC of SC_JEXPBOOST to separate the SC type used to JOB_Battle_Manual.
So this would be the item_db look like.
CODE
14592,JOB_Battle_Manual,JOB Battle Manual,2,2,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ sc_start SC_JEXPBOOST,1800000,50; },{},{}
About its SI in code I have finished, I used SI_CASH_PLUSONLYJOBEXP which I think its better because only Job exp will be boost. And when you used it there is a dispbottom 'Job exp... something ' that will notify you..
But right now official servers uses still SI_EXPBOOST. But for me its better to use the other SI which I think the official one.
Fix Code UPDATED. Try more cleaner
NOTE: The code inside the diff is fully tested and 100% working.
Hoping for devs reply of this bug report and included the fix on it. (IMG:style_emoticons/default/biggrin.gif)
This post has been edited by GMJobbie: Jun 4 2009, 07:30 PM