Issue information

Issue ID
#3249
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jun 15, 2009 0:12
Last Post
Hercules Elf Bot
Jun 15, 2009 0:12
Confirmation
N/A

Hercules Elf Bot - Jun 15, 2009 0:12

Originally posted by [b]Ancyker[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3249

(I chose both branches on an assumption, not a confirmation)

killerrid and killedrid are being saved into global_reg_value. This is taking up space and degrading performance of this table for nothing. These should be hard coded not to save or changed to @vars. Changing to @vars, or even .@vars, makes sense as these are called once during a script and then discarded at the end, there is really no reason for them to persist once a script has ended.

This MySQL query will delete stale data:
CODE
DELETE FROM `global_reg_value` WHERE `str` = 'killedrid' OR `str` = 'killerrid';


This NPC is a work around, it will unset them on log out:
CODE
- script KillridWorkAround -1,{
OnPCLogoutEvent:
set killerrid,0;
set killedrid,0;
end;
}


This post has been edited by Ancyker: Jun 14 2009, 05:31 PM