Hercules Elf Bot - Jun 20, 2009 20:28
Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3276
Alright, so...
1. I wish that the map_instance_* functions were renamed to instance_*, and moved to instance.c/h. The instancing system uses separate structures and therefore has no place in map.c (less messy this way).
2. Using a custom-rigged crc32() function to generate an "unique identifier". Are you out of your mind(s)? If you really need an unique id that badly, use a pointer's memory address (which won't change). Crc32, nor any hash function, cannot guarantee uniqueness.
3. In map.h, int instance_map[1000]; was added to each and every map. This causes a ~3MB memory overhead waste. Please get rid of this.
4. Externalizing npcname_db to be able to duplicate npcs... why not make a npc duplication function for npc.c and export that?
5. What is the purpose of the new 'variables?