inconsistent skill data saving

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3380

1. Skills with 'id != 0 and 'lv' = 0 are getting saved to the sql database. Not sure about txt.
Not sure what produces these. Maybe skill reset. Whatever the cause might be, this is producing hundreds of thousands of 'zero' skill table entries. I do not know if this is the same as not having the skill at all, or not.

2. When saving 'forgotten' skills (marked as 'id' = 0, 'lv' != 0), sql restores the id before saving; txt doesn't, and therefore doesn't save these skills.

[code] for(i=0;i<MAX_SKILL;i++)
if ((p->skill[i].lv != 0) && (p->skill[i].id == 0))
p->skill[i].id = i; // Fix skill tree[/code]

It's from [rev=764]!