Several bugs in other/arena/

Originally posted by [b]NoH[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3494

NB: 1) and 2) can be found in evey arena_lv** file of the folder.

1) The areawarps to get out of the rewards room at the end of the race use messy coordinates, ex:

[code]areawarp "prt_are_in",22,183,20,20,"arena_room",100,75;[/code]

so the players in the zone will never be warped (isn't x1 supposed to be <x2 - idem for y - anyway?).

NB: can possibly be used to stay in the room and steal the rewards of the next players (not tested, but since the script seems to use server variables...).

The right coords are:

lvl 50: 14,178,29,195,
lvl 60: 14,126,29,143,
lvl 70: 14,74,29,91,
lvl 80: 170,178,185,195,
Party: 170,126,185,143,

2) The announces in this room and the related NPC events (including the messy mapwarp) will be triggered only if the player beats the game. They won't if he fails to pass every stage.

Fix, find:

[code]OnTimer305000:
OnTimer306000:
OnTimer307000:
OnTimer308000:
OnTimer309000:
OnTimer310000:
OnTimer311000:
OnTimer312000:
OnTimer313000:
OnTimer314000:
mapwarp "force_1-1","prt_are_in",126,190,0,0;
end;

OnTimer315000:
mapwarp "force_1-1","prt_are_in",126,190,0,0;
donpcevent "Heel and Toe#arena::Onfailclearstage";
end;[/code]

and add somewhere in this mess (what the hell with the mapwarps every second?):

[code] donpcevent "#arn_timer_50::Onon";[/code]

(of course the NPC name depends on the file: here it's for the lvl 50 arena).

3) In arena_room.txt, the GM helper can be used by any player who has the password (and the password is in the NPC files). Of course, they also need to be able to talk to him to do bad things (ie: to warp to sec_in02), but on some servers it could be a bad bug. Quick fix:

[quote]sec_in02,72,180,3 script Arena Manager#arena 802,{
[b] if (!getgmlevel()) end; // Bugfix
[/b] input .@arena;
if(!.@arena)
{[/quote]

Same problem with the NPC "Reward Manager#arena" a little further in the script.

4) In the same NPC, when changing the time for the records:

[code] mes "Please enter 0 to cancel.";
mes "If not, please write within 400 letters.";
next;
input .@arenamin;
set $top_50min,.@arenamin;
input .@arenasec;
set $top_50sec,.@arenasec;[/code]

Obviously it's not letters, and it should be 2, and not 400 (at least for the seconds - 10ish, I don't remember, for the minutes).

5) In arena_lvl60:

[code]donpcevent "cast#60::timeover2";[/code]

-> should be "OnTimeover2".