Issue information

Issue ID
#357
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Nov 3, 2007 12:43
Last Post
Hercules Elf Bot
Nov 3, 2007 12:43
Confirmation
N/A

Hercules Elf Bot - Nov 3, 2007 12:43

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=357

While doing random code changes, I noticed something rather odd. It's the various macros that use unit_stop_attack.

CODE
#define pc_stop_attack(sd)   { if((sd)->ud.attacktimer != -1) { unit_stop_attack(&(sd)->bl); (sd)->ud.target = 0; } }
#define mob_stop_attack(md)  { if((md)->ud.attacktimer != -1) unit_stop_attack(&(md)->bl); }
#define pet_stop_attack(pd)  { if((pd)->ud.attacktimer != -1) unit_stop_attack(&(pd)->bl); }
#define merc_stop_attack(hd) { if((hd)->ud.attacktimer != -1) unit_stop_attack(&(hd)->bl); hd->ud.target = 0; }

Notice the subtle differences. Players don't unlock their target if their attack timer is not running. Homunculi do it so or so
And mobs/pets don't unlock their target at all when this command is issued.

Is this 'inconsistency' intended?

This post has been edited by theultramage: Dec 20 2007, 07:49 AM