Issue information

Issue ID
#3599
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Sep 16, 2009 19:26
Last Post
Hercules Elf Bot
Sep 16, 2009 19:26
Confirmation
N/A

Hercules Elf Bot - Sep 16, 2009 19:26

Originally posted by [b]Gepard[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3599

NPCs have their display names defined here: http://svn.eathena.ws/bugs/browser/trunk/s....h?marks=34#L10
It's NAME_LENGTH+1 long. I don't know what for "+1" is, because NAME_LENGTH is alredy 23+1 for EOS.

When unloading NPC using @unloadnpc, name is scanned into
CODE
//atcommand.c line 4733
char NPCname[NAME_LENGTH];


So it's impossible to unload NPC with name 24 characters long. However, it's possible to load such NPCs without any errors/warnings.

It's very easy to change NAME_LENGTH to NAME_LENGHT+1 but the question is: should it be this or the other way? Maybe npc_data should be changed, not the command?