Issue information

Issue ID
#3644
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Oct 12, 2009 13:46
Last Post
Hercules Elf Bot
Mar 5, 2012 14:31
Confirmation
N/A

Hercules Elf Bot - Oct 12, 2009 13:46

Originally posted by [b]SoulBlaker[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3644

in events/valentinesday_2009.txt (line 69)

var incorrect line:

if (.@val09choco > 5)

Correction:

.@input

Current code:

CODE
while(.@input <= 0 || .@input > 5) {
                input .@input;
                if (.@input < 1) {
                    mes "[Marco Bassinio]";
                    mes "Oh, it's such a shame!";
                    mes "I'm sure you'll miss";
                    mes "this opportunity and";
                    mes "regret you didn't buy it.";
                    next;
                    mes "[Marco Bassinio]";
                    mes "Remember, you can never";
                    mes "find this anywhere else!";
                    mes "Come back anytime,";
                    mes "when you change your mind.";
                    close;
                }
                if (.@val09choco > 5) {
                    mes "[Marco Bassinio]";
                    mes "Ugh.. Didn't I tell you?";
                    mes "5 is the maximum!";
                    mes "I can't sell more than";
                    mes "that to the same person.";
                    next;
                    mes "[Marco Bassinio]";
                    mes "And you know it's not";
                    mes "like an everyday meal.";
                    mes "Eating too much is not";
                    mes "really good for you.";
                    next;
                }
            }


Fixed:

CODE
while(.@input <= 0 || .@input > 5) {
                input .@input;
                if (.@input < 1) {
                    mes "[Marco Bassinio]";
                    mes "Oh, it's such a shame!";
                    mes "I'm sure you'll miss";
                    mes "this opportunity and";
                    mes "regret you didn't buy it.";
                    next;
                    mes "[Marco Bassinio]";
                    mes "Remember, you can never";
                    mes "find this anywhere else!";
                    mes "Come back anytime,";
                    mes "when you change your mind.";
                    close;
                }
                if (.@input > 5) {
                    mes "[Marco Bassinio]";
                    mes "Ugh.. Didn't I tell you?";
                    mes "5 is the maximum!";
                    mes "I can't sell more than";
                    mes "that to the same person.";
                    next;
                    mes "[Marco Bassinio]";
                    mes "And you know it's not";
                    mes "like an everyday meal.";
                    mes "Eating too much is not";
                    mes "really good for you.";
                    next;
                }
            }


There is a script so important, it has put a small mistake, even if a var Puch another npc, it would be wrong because the syntax is a var in the temporary npc.

There is also a next; inside the comparison, is hitting less than 1 or greater than 5 is false should be a close; anymore, it's up to you now that I know of this event.

This post has been edited by SoulBlaker: Oct 12 2009, 06:48 AM