Hercules Elf Bot - Oct 16, 2009 5:57
Originally posted by [b]Euphidime[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3654
When placing items in storage/guild storage, the account/guild ID is not in the pick log entry. This makes it possible to move items between characters/accounts without being able to follow where they went in the log.
Example: Character A and Character B are on separate accounts, but in the same guild. Character A moves Jellopy into guild storage. Character B removes Jellopy from guild storage. Your only hope for telling where this Jellopy went is to look up what guild Character A is in and hope it's the same guild they were in at the time. Character A only needs to be deleted, leave the guild, or break the guild, and it is then impossible to trace where the Jellopy went.
This problem also exists with account storage, but it's just annoying, not a way to steal items without being traced. This is because if a character is deleted, you have no way to tell what account that character was on, unless you know the name. Picklog doesn't contain name, and charlog doesn't contain char ID, only slot.
Solution: Add a type_id column to picklog that contains either the account or guild ID when moving to/removing from account/guild storage. Also, char ID should probably be added to the charlog.
Hercules Elf Bot - Dec 20, 2011 5:07
Originally posted by [b]Ind[/b]
quoting from original bug report
[quote]
Charlog DOES contain deleted character IDs, in the string field "charmsg" as "Deleted Char (CID #######)". Making a char ID column would definitely be better though since it can be indexed and searched faster as you don't have to search through each and every string in the charlog.
(Also as a side note logging character selections is pretty much useless and inflates the charlog table far more than it needs to be :S)
[b]As for guild storages, that's definitely a major weakness. When guilds are broken their guild storages are also wiped and this action is not logged at all. The items should be either logged (as deleted from guild storage) or the guild storage itself remain intact when the guild is broken.[/b][/quote]
Hercules Elf Bot - Jan 3, 2012 0:23
Originally posted by [b]Gepard[/b]
Also, last time I checked it, storage was also wiped on character delete and this action was not logged, just like with guilds and their storages.