Issue information

Issue ID
#3934
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Dec 13, 2009 4:33
Last Post
Hercules Elf Bot
Mar 5, 2012 14:52
Confirmation
N/A

Hercules Elf Bot - Dec 13, 2009 4:33

Originally posted by [b]NoH[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3934

Sorry, I'm gonna make it short (too lazy to write again what was deleted).

CODE
if ((guildrelay_q == 86) && (BaseClass == Job_Alchemist))


->

CODE
if ((guildrelay_q == 86) && (BaseJob == Job_Alchemist))


CODE
                mes "Oh, really?";
                mes "That's too bad...";
                mes "My apologies, but";
                mes "I can't allow strangers";
                mes "to simply come and go";
                mes "around here. Farewell, then.";
                next;
                warp "alde_gld",186,157;


->

CODE
                mes "Oh, really?";
                mes "That's too bad...";
                mes "My apologies, but";
                mes "I can't allow strangers";
                mes "to simply come and go";
                mes "around here. Farewell, then.";
                next;
                getmapxy(.@m$,.@x,.@x,1);
                if ( .@m$ == "aldeg_cas01" || .@m$ == "aldeg_cas02" || .@m$ == "aldeg_cas03" || .@m$ == "aldeg_cas04" || .@m$ == "aldeg_cas05"  ) warp "alde_gld",186,157;
                else if ( .@m$ == "gefg_cas01" || .@m$ == "gefg_cas02" || .@m$ == "gefg_cas03" || .@m$ == "gefg_cas04" || .@m$ == "gefg_cas05"  ) warp "gef_fild13",183,240;
                else if ( .@m$ == "payg_cas01" || .@m$ == "payg_cas02" || .@m$ == "payg_cas03" || .@m$ == "payg_cas04" || .@m$ == "payg_cas05"  ) warp "pay_gld",268,199;
                else if ( .@m$ == "prtg_cas01" || .@m$ == "prtg_cas02" || .@m$ == "prtg_cas03" || .@m$ == "prtg_cas04" || .@m$ == "prtg_cas05"  ) warp "prt_gld",160,92;


... or you're gonna have a free warp to aldebaran if you'ren not in alde_cas01. The x/y values are randmish.

CODE
    if (.@name$ == "Lenya") {
        set .@GID, GetCastleData("aldeg_cas"+strnpcinfo(2),1);
    }


->

CODE
    getmapxy(.@m$,.@x,.@x,1);
    set .@GID, GetCastleData(.@m$,1);


CODE
    if (.@name$ == "Gealuve") {  // Bugfix - ils testent leurs scripts des fois chez eA? [No Healing]
        set .@GID, GetCastleData("aldeg_cas"+strnpcinfo(2),1);
    }


->

CODE
    getmapxy(.@m$,.@x,.@x,1);
    set .@GID, GetCastleData(.@m$,1);


CODE
    if (.@name$ == "Pariz") {  // Bugfix - ils testent leurs scripts des fois chez eA? [No Healing]
        set .@GID, GetCastleData("aldeg_cas"+strnpcinfo(2),1);
    }


->

CODE
    getmapxy(.@m$,.@x,.@x,1);
    set .@GID, GetCastleData(.@m$,1);


or the script won't work outside aldeg_cas01.

-------------------------------------

Now this is completely off-topic and it's probably not the place to talk about that (and please don't take offense: I'm not here to hear a dev tell me to f*** off as the last time), but don't you think eA needs some new scripts testers? I mean.... I know those files pretty well for one reason: I did translate them into french. And I also noticed whenever I translate something a little bit complex, there are plenty of bugs (I'm NOT a candidate btw). I noticed as well it takes ages to have them fixed, even when they're pretty bad, unless it's just a typo or something minor.

I'm not blaming the current devs: I know they may have better things to do, but don't you think the project may benefit from new script testers?

This post has been edited by NoHealing: Dec 12 2009, 08:34 PM