Issue information

Issue ID
#397
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Nov 10, 2007 3:13
Last Post
Hercules Elf Bot
Nov 10, 2007 3:13
Confirmation
N/A

Hercules Elf Bot - Nov 10, 2007 3:13

Originally posted by [b]Ai4rei[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=397

Following NPCs has some useless code (set name,PcName;), which looks like a leftover from previus revisions, since it isn't used anywhere else:
/npc/jobs/2-1/priest.txt, Line: 1552
/npc/jobs/2-1/priest.txt, Lines: 594, 1898
/npc/jobs/2-2/rogue.txt, Lines: 1041, 1113
/npc/jobs/2-2/dancer.txt, Line: 154
/npc/jobs/2-2/monk.txt, Line: 1953

Following has old variable resets (set <jobname>_t,0;) but since temporary npc variables are used, this reset isn't needed anymore:
/npc/jobs/2-1/hunter.txt, Lines: 221, 405 (I ask myself why "knight"-variables are present in hunter quest..)
CODE
set knight_t,0;

/npc/jobs/2-1/knight.txt, Lines: 1851, 2258
/npc/jobs/2-2/rogue.txt, Lines: 970, 1042, 1114
/npc/jobs/2-2/crusader.txt, Line: 509 (This initialization also isn't needed, since the test can be done only once per npc-"session".)
CODE
set .@cru_t,0;

/npc/jobs/2-2/sage.txt, Line: 994