Orc's Memory - 2 Player in a Party

Originally posted by [b]Masao[/b]
Unfortunatly this is one of the Problems we're dealing with since ages in eA, but also as far as i know, it works this way too on official servers?

If it doesn't work like that on official servers, someone can provide ma link with proof for it?

Originally posted by [b]sizenine[/b]
Also it doesn't check for base level requirement of other partymates

Originally posted by [b]Masao[/b]
Fixed in [rev=16107]

About the lvl issue, well i could fix it but i won't, since i myself at least would need to use sql querys in order to do so, which would end up in performance issues.

But if anyone else knows how to do this in another way, feel free to tell me.

Originally posted by [b]Lemongrass[/b]
[quote name='Masao' timestamp='1336856111' post='9188']
Fixed in [rev=16107]About the lvl issue, well i could fix it but i won't, since i myself at least would need to use sql querys in order to do so, which would end up in performance issues.But if anyone else knows how to do this in another way, feel free to tell me.
[/quote]

if you already check if the player is online, just attach him and check his baselevel?

or do something like(pseudo code):

[code]
array = getparymembers();
count = 1; // player himself

for( i = 0; i < count(array); i++ ){
if( attach( array[i] ) && baselevel >= requiredlevel ){
// player is online and attached and has the right baselevel
count++;
}
}
[/code]

get my idea?

Originally posted by [b]QQfoolsorellina[/b]
[quote name='Masao' timestamp='1336856111' post='9188']
Fixed in [rev=16107]About the lvl issue, well i could fix it but i won't, since i myself at least would need to use sql querys in order to do so, which would end up in performance issues.But if anyone else knows how to do this in another way, feel free to tell me.
[/quote]

Hi Masao,
it still bugged

I notice the .@loggedin value always 0


my temporary solution:
[code]

getpartymember(.@party_id),1;
getpartymember(.@party_id),2;
set .@partymembercount,$@partymembercount;
copyarray .@partymemberaid,$@partymemberaid[0],.@partymembercount;
copyarray .@partymembercid,$@partymembercid[0],.@partymembercount;
for(set .@i,0; .@i < .@partymembercount; set .@i,.@i+1){
if(isloggedin(.@partymemberaid[.@i],.@partymembercid[.@i])){
set .@loggedin,.@loggedin+1;
}
}

[/code]

Originally posted by [b]Masao[/b]
@[url="http://rathena.org/board/user/413-qqfoolsorellina/"]QQfoolsorellina[/url] : No clue why it doesn't work for you, i've texted that script several times on my test server, using the original instance npc's and an test npc to check the isloggedin function itself, and it always worked for me.

Originally posted by [b]QQfoolsorellina[/b]
[quote name='Masao' timestamp='1336911316' post='9210']
@[url="http://rathena.org/board/user/413-qqfoolsorellina/"]QQfoolsorellina[/url] : No clue why it doesn't work for you, i've texted that script several times on my test server, using the original instance npc's and an test npc to check the isloggedin function itself, and it always worked for me.
[/quote]


I cant entry the instant it always show the below message

http://3.imgland.net/7vu5h.jpg



in picture the announce '0' is my addtion script to show the value of [b].@loggedin[/b]

[code]
for(set .@i,0; .@i < .@partymembercount; set .@i,.@i+1){
if(isloggedin($@partymemberaid[.@i],$@partymembercid[.@i])){
set .@loggedin,.@loggedin+1;
}
}
+ announce ""+.@loggedin,8;// this is the only script add by me
[/code]

Originally posted by [b]Masao[/b]
Should finally be fixed in [rev=16111] i hope.

Originally posted by [b]Lemongrass[/b]
[quote name='Masao' timestamp='1336945367' post='9217']
Should finally be fixed in [rev=16111] i hope.
[/quote]

Since you seem to ignore me, here's a small diff for a fix that should work and even provide the possibility to check the required level of the online players.

Please mind that I haven't had the time to test it on a running server, but there weren't any compiling issues.

Feel free to add it to the SVN, but please add a credit if you do so.

Originally posted by [b]Masao[/b]
@Lemongrass

I'm not ignoring you, but this report is about the issue of 2 players which need to be online and in a party in order to join the instance ^^ The level issue is something different, which i sure will also take care of some time, and thank you for your input, but it's not on position 1. on my To-Do list.

Originally posted by [b]Masao[/b]
Fixed in [rev=16135] .