Issue information

Issue ID
#3984
Status
Working as Intended
Severity
None
Started
Hercules Elf Bot
Dec 29, 2009 22:48
Last Post
Hercules Elf Bot
Dec 29, 2009 22:48
Confirmation
N/A

Hercules Elf Bot - Dec 29, 2009 22:48

Originally posted by [b]Dark Poet[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3984

After doing some investigation on the quest log, 0x02B5 appears to be getting sent by the server with an abnormal length.

According to data submitted by k.LabMouse on the quest log system, the packet length varies by the number of mobs in the quest.
CODE
struct PACKET_ZC_UPDATE_MISSION_HUNT {
      short PacketType;
      short PacketLen;
      short updateMissionNum;
      struct UPDATE_MISSION_RECORD {
        unsigned long questID;
        unsigned long mobID;
        short mobHunt;
      } update_missions[updateMissionNum];  // Actually, Client determinate this value by PacketLength
    };


Therefore, by creating a monster extermination quest with 1 target mob, the packet should not be any larger than 1*10+6 bytes long. This length is supported in clif_quest_update_objective; however, I have captured this packet being sent from the server at outrageous and varying lengths.

Examples:
CODE
B5 02 10 00 01 00 CB EA 00 00 EF 03 00 00 08 00 B1 00 01 00 6E 12 00 00 B1 00 02 00 12 10 00 00 80 00 94 77 8E 06 01 9E 00 1A 00 00 00 DD 05 00 2C 01 C1 00 09 0C 01 00 9E 00 1B 00 00 00 C1 02 01 2C 01 C3 00 06 06 01 00 9E 00 1C 00 00 00 FF 01 01 2C 01 C2 00 03 09 01 00 9E 00 1D 00 00 00 DE 05 00 2C 01 C1 00 0C 03 01 00 9E 00 1E 00 00 00 B5 03 01 2C 01 C3 00 09 03 01 00 9E 00 1F 00 00 00 92 03 01 2E 01 C2 00 06 0C 01 00

CODE
B5 02 10 00 01 00 CB EA 00 00 EF 03 00 00 0A 00 B1 00 01 00 F5 0E 00 00 B1 00 02 00 B2 1F 00 00 80 00 96 77 8E 06 01 9E 00 26 00 00 00 DD 05 00 2B 01 B9 00 0C 03 01 00 9E 00 27 00 00 00 C1 02 01 2D 01 B8 00 06 06 01 00 9E 00 28 00 00 00 FF 01 01 2D 01 B9 00 06 09 01 00 9E 00 29 00 00 00 B5 03 01 2D 01 B9 00 03 09 01 00 9E 00 2A 00 00 00 92 03 01 2C 01 B8 00 0C 03 01 00


More captures show that there are packets being sent well over 300 bytes in length when the maximum length as determined by clif_quest_update_objective should be 16 bytes. Therefore, the only data that should be received in a single target monster-hunting quest is:
CODE
B5 02 10 00 01 00 CB EA 00 00 EF 03 00 00 08 00


Possible overflow of data in WFIFOSET somewhere? I've been trying to figure it out but have yet to come to any solution.

This post has been edited by Dark Poet: Dec 29 2009, 11:18 PM