Issue information

Issue ID
#40
Status
Working as Intended
Severity
None
Started
Hercules Elf Bot
Sep 11, 2007 21:39
Last Post
Hercules Elf Bot
Sep 11, 2007 21:39
Confirmation
N/A

Hercules Elf Bot - Sep 11, 2007 21:39

Originally posted by [b]code_orange[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=40

I am calling this a serious bug, because I could not find any explanation or intention as to why the following situation was created. Plus, I can't search for EDP that well in the search box because of the short word limit.


Before SVN [9492], EDP added its +300% damage bonus at level 5 (level 5 used as example) to skillratio in battle.c, upping a Sonic Blow from 800% to 1100%. Afterwards, since the +xxx% buffs were modified to stack on top of skillratio, the damage increased from 800% to 3200%. For another example, Grimtooth increased from 200% (level 5) to 500%, and currently the damage increases from 200% to 800%.

ATK_ADDRATE multiplies and adds the ratio given, which is not a straight addition. I thought this was kind of strange, since EDP gained a huge increase in power after that SVN update, and it didn't seem to be intentional. I recall reading a long time ago that EDP would only stack the damage increase on Sonic Blow and not multiply. If there is a source for the change in EDP's implementation, I would like to see it.