Super Novice, things that should be fixed

Originally posted by [b]Kazukin[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4053

Super Novice Angel, which triggers when their HP reaches 0, saving them from death and granting them Steel Body if their EXP is at 99% or they have reached the EXP cap has some quirks that should be fixed.
1. Super Novices shouldn't lose their all stats +10 bonus when they are saved by their Angel, on eA, they do. This happens because death counter is incremented when they are saved. It shouldn't.
2. Super Novices shouldn't lose pet intimacy, their mercenaries, drop skulls on pvp??,etc. and others checks that are performed on pc_dead() before checking whether the super novice Angel will save them.
3. Steel body level granted by the Angel should be lv5 instead of lv1.
4. When a super novice is saved by their angel, Steel Body animation should show as if it was casted by the super novice.
5. Super Novices should be saved by their Angel on WOE and GVG maps.
6. Super Novices can be saved by their Angel from death once every relog AND once after every time they respawn on their Save Point after having died.

Some sources and past reports:
http://www.youtube.com/watch?v=yNkvhSmZm4I...feature=related
http://www.eathena.ws/board/index.php?show...63565&st=60
http://iro.ragnarokonline.com/forum/forums...14&start=61
http://www.eathena.ws/board/index.php?auto...mp;showbug=2906

Searching for 'super novice' on the bug tracker will yield a few dozens more.

My personal fix (line numbers probably won't match since its from my modded src):
http://pastebin.com/f47eb1385

This post has been edited by Kazukin: Aug 27 2011, 11:08 AM