Issue information

Issue ID
#4088
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Mar 5, 2010 15:48
Last Post
Hercules Elf Bot
Apr 4, 2012 7:14
Confirmation
N/A

Hercules Elf Bot - Mar 5, 2010 15:48

Originally posted by [b]NoH[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4088

CODE
    else if (rachel_camel <= 16) {
        mes "^3355FFYou already found the";
        mes "camel, so you need to collect";
        mes "the soap ingredients if you";
        mes "want to free Curdie.^000000";
        close;


->

CODE
    else if (rachel_camel >= 12 && rachel_camel <= 16) {
        mes "^3355FFYou already found the";
        mes "camel, so you need to collect";
        mes "the soap ingredients if you";
        mes "want to free Curdie.^000000";
        close;


... or this part is gonna be triggered if you have not started the quest yet (!rachel_camel), which is meaningless.

CODE
    else if (aru_vol == 14) {
        mes "[Colonel Vito]";
        mes "What are you still";
        mes "doing standing there?";
        mes "Don't slack off! Come!";
        close2;
        warp "thor_camp",156,68;
        end;


If aru_vol == 13 (right before this part of code, it enables the npc, then disables it after the dialog. You must do the same here, or a player who has aru_vol at 14 may not be able to talk to this npc if he's disabled by a player with aru_vol at 13. So:

CODE
    else if (aru_vol == 14) {
        enablenpc "Colonel Vito#1"; // Bugfix
        mes "[Colonel Vito]";
        mes "What are you still";
        mes "doing standing there?";
        mes "Don't slack off! Come!";
        close2;
        disablenpc "Colonel Vito#1"; // Bugfix
        warp "thor_camp",156,68;
        end;


Right under this piece of code, we have a similar NPC, with almost the same dialog, but this time only the "enablenpc" part is missing:

CODE
    else if (aru_vol == 14) {
        mes "[Colonel Vito]";
        mes "What are you still";
        mes "doing standing there?";
        mes "Don't slack off! Come!";
        close2;
        disablenpc "Colonel Vito#2";
        warp "thor_camp",156,68;
        end;


->

CODE
    else if (aru_vol == 14) {
        enablenpc "Colonel Vito#2"; // Bugfix – je rajoute ça
        mes "[Colonel Vito]";
        mes "What are you still";
        mes "doing standing there?";
        mes "Don't slack off! Come!";
        close2;
        disablenpc "Colonel Vito#2";
        warp "thor_camp",156,68;
        end;


CODE
thor_camp,98,213,5    script    Thor Volcano Soldier#vo8    939,{


Wrong coordinates: the dialog is meaningless where the NPC is, it should be "thor_camp,187,232,5" for example. Yeah, I know, it's an Aegis bug, but it's a bug nevertheless.

This post has been edited by NoH: Mar 8 2010, 04:07 PM

Hercules Elf Bot - Mar 11, 2012 22:03

Originally posted by [b]Kenpachi[/b]
Fixed in [rev=15678].

Hercules Elf Bot - Mar 13, 2012 22:17

Originally posted by [b]EvilPuncker[/b]
-mes "this day! Long live "+username+"!";
+mes "this day! Long live "+strcharinfo(0)+"!";

Hercules Elf Bot - Mar 14, 2012 11:44

Originally posted by [b]Kenpachi[/b]
Sorry, my bad. (Should I start using converters? ^^)

Hercules Elf Bot - Mar 19, 2012 1:12

Originally posted by [b]Slim[/b]
Fixed typo -> [url="http://sourceforge.net/apps/trac/rathena/changeset/15727/"]r15727[/url]