The Sign Quest

Originally posted by [b]Bison[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=41

While I'm sure it existed before this revision, I will just say it's the latest. Anyway, there's a small bug with the quest.

Starting at around line 5723 of The_Sign_Quest.txt:

[codebox]
set @engelhour,gettime(3);
set @engelmin,gettime(2);
if (@engelmin > 29) set @engelhour,@engelhour +1;
set signengelhour,@engelhour + rand(2,4);
if (signengelhour > 23) set signengelhour,signengelhour - 24;
set signquest,62;
close;

L_Hour:
if (gettime(3) == signengelhour || gettime(3) == signengelhour +1 || gettime(3) == signengelhour +2) {
[/codebox]

Anyway, it's all fine till you hit the check at the bottom. The variable "signengelhour" obviously stores the hour, however, since the check allows for a plus 0-2 hour leeway to report back, there is a problem when you have "signengelhour" at 22 or 23. Correct me if I'm wrong, but gettime(3) would return a 0 instead of 24, and there isn't a 25th hour either, so the player essentially loses an hour or two for checking back to the NPC.

Again, as I stated earlier, not a huge bug, but player convenience wise, it can be annoying for them.

Edit: The codebox isn't quite displaying for me properly in the normal post view, only the preview post shows the codebox correctly. :(

Edit2: Oops, just realized there was a report section for scripts. If someone could move it over there for me, thank you. :(

This post has been edited by Bison: Sep 11 2007, 06:17 PM