Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#4101
Status
Working as Intended
Severity
None
Started
Hercules Elf Bot
Mar 5, 2010 23:24
Last Post
Hercules Elf Bot
Mar 5, 2012 16:05
Confirmation
N/A
Hercules Elf Bot - Mar 5, 2010 23:24
Originally posted by [b]NoH[/b] http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4101
[code] if (nif_esc == 11) {
set nif_esc,12;
delitem 7184,6; //Piano_Keyboard[/code]
Pretty bad if the player doesn't have 6 keys on him:
[code] if (nif_esc == 11) {
set nif_esc,12;
delitem 7184,countitem(7184); //Piano_Keyboard[/code]
This post has been edited by
Brian
on Dec 14, 2011 18:04
Hercules Elf Bot - Dec 28, 2011 16:14
Originally posted by [b]Jguy[/b] Reading the comments on eAthena's bugtracker, this is a toss up between working as intended and horribly broken.
You are correct, if the player does not have all the keys on him, it could be pretty bad...but theoretically, they should at that point of the quest, so there shouldn't be a problem. Afterall, if they followed all of the questline up to this point, they would have had to have gotten all the keys.
The correct solution here would be to have script execution stopped when delitem detects that what the function is trying to delete isn't there. That is official behaviour on AEGIS. This behaviour was introduced with eAthena [rev=13368], so I would consider this 'Working as Intended'.